From: Linus Torvalds <torvalds@linux-foundation.org>
To: NeilBrown <neilb@suse.de>
Cc: Christian Brauner <brauner@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Jeff Layton <jlayton@kernel.org>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RFC v2 5/6] inode: port __I_LRU_ISOLATING to var event
Date: Fri, 23 Aug 2024 10:24:57 +0800 [thread overview]
Message-ID: <CAHk-=wgocMvG7Lcrju7PgnWfUfsr3fEVOk=gwmGOhtTOdYdNjA@mail.gmail.com> (raw)
In-Reply-To: <172437341576.6062.4865045633122673711@noble.neil.brown.name>
On Fri, 23 Aug 2024 at 08:37, NeilBrown <neilb@suse.de> wrote:
>
> I would really like to add
>
> wait_var_event_locked(variable, condition, spinlock)
>
> so that above would be one or two lines.
We don't even have that for the regular wait_event, but we do have
wait_event_interruptible_locked
wait_event_interruptible_locked_irq
but they actually only work on the wait-queue lock, not on some
generic "use this lock".
Honestly, I like your version much better, but having two *very*
different models for what "locked" means looks wrong.
The wait-queue lock (our current "locked" event version) is a rather
important special case, though, and takes advantage of holding the
waitqueue lock by then using __add_wait_queue_entry_tail() without
locking.
"You are in a maze of twisty little functions, all alike".
Linus
next prev parent reply other threads:[~2024-08-23 2:25 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 15:47 [PATCH RFC v2 0/6] inode: turn i_state into u32 Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 1/6] fs: add i_state helpers Christian Brauner
2024-08-21 22:12 ` NeilBrown
2024-08-21 22:47 ` Linus Torvalds
2024-08-21 23:34 ` Dave Chinner
2024-08-23 0:08 ` NeilBrown
2024-08-22 8:27 ` Christian Brauner
2024-08-22 8:37 ` Linus Torvalds
2024-08-23 0:14 ` NeilBrown
2024-08-23 2:52 ` Linus Torvalds
2024-08-23 3:05 ` Linus Torvalds
2024-08-23 3:44 ` Linus Torvalds
2024-08-23 5:01 ` NeilBrown
2024-08-23 12:47 ` [PATCH v3 0/6] inode: turn i_state into u32 Christian Brauner
2024-08-23 12:47 ` [PATCH v3 1/6] fs: add i_state helpers Christian Brauner
2024-09-05 16:01 ` Jan Kara
2024-08-23 12:47 ` [PATCH v3 2/6] fs: reorder i_state bits Christian Brauner
2024-09-05 16:02 ` Jan Kara
2024-08-23 12:47 ` [PATCH v3 3/6] inode: port __I_SYNC to var event Christian Brauner
2024-09-05 16:02 ` Jan Kara
2024-08-23 12:47 ` [PATCH v3 4/6] inode: port __I_NEW " Christian Brauner
2024-09-06 13:30 ` Jan Kara
2024-08-23 12:47 ` [PATCH v3 5/6] inode: port __I_LRU_ISOLATING " Christian Brauner
2024-09-09 7:35 ` Jan Kara
2024-08-23 12:47 ` [PATCH v3 6/6] inode: make i_state a u32 Christian Brauner
2024-09-09 7:35 ` Jan Kara
2024-08-23 15:06 ` [PATCH v3 0/6] inode: turn i_state into u32 Josef Bacik
2024-08-21 22:28 ` [PATCH RFC v2 1/6] fs: add i_state helpers Dave Chinner
2024-08-21 22:53 ` Linus Torvalds
2024-08-21 15:47 ` [PATCH RFC v2 2/6] fs: reorder i_state bits Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 3/6] writeback: port __I_SYNC to var event Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 4/6] inode: port __I_NEW " Christian Brauner
2024-08-23 0:31 ` NeilBrown
2024-08-23 8:20 ` Christian Brauner
2024-08-23 11:07 ` Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 5/6] inode: port __I_LRU_ISOLATING " Christian Brauner
2024-08-21 19:41 ` Jeff Layton
2024-08-22 8:53 ` Christian Brauner
2024-08-22 9:48 ` Mateusz Guzik
2024-08-22 11:10 ` Christian Brauner
2024-08-22 12:46 ` Mateusz Guzik
2024-08-23 0:36 ` NeilBrown
2024-08-23 2:24 ` Linus Torvalds [this message]
2024-08-23 8:29 ` Christian Brauner
2024-08-21 15:47 ` [PATCH RFC v2 6/6] inode: make i_state a u32 Christian Brauner
2024-08-21 21:03 ` Andreas Dilger
2024-08-22 8:31 ` Christian Brauner
2024-08-21 19:15 ` [PATCH RFC v2 0/6] inode: turn i_state into u32 Josef Bacik
2024-08-21 19:42 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wgocMvG7Lcrju7PgnWfUfsr3fEVOk=gwmGOhtTOdYdNjA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).