From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A04EAEB64DD for ; Fri, 11 Aug 2023 05:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231643AbjHKFUn (ORCPT ); Fri, 11 Aug 2023 01:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231588AbjHKFUm (ORCPT ); Fri, 11 Aug 2023 01:20:42 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA11D2D54 for ; Thu, 10 Aug 2023 22:20:41 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fe700f9bf7so2568298e87.0 for ; Thu, 10 Aug 2023 22:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1691731240; x=1692336040; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=8cYlwrRaSF/zKzc5TC0jLD+97834wyo6L2H6kEGojaI=; b=FEUK1OLz9JahRHaIkJh/Uy4K1qGoMOXtSDrnGB4u7hY0E0lxDjpYirXOU6e+8XD32Y 53Fl7mnPazPoIri6lRx8roZPc8Lm1q2PC8uS/PIzupAVPCm7aVFirExBmcMDlBcoBGtO QaB0FLOmXWgTu5lDFqaekvJD1+OGeoPNnQvEI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691731240; x=1692336040; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8cYlwrRaSF/zKzc5TC0jLD+97834wyo6L2H6kEGojaI=; b=h2RBIvx5KwNXY6C/G0hO1z3qq8fO3PjbjMs0hbDTtja4hT0kNdHpLurtYlGUm9MAZM EPUiCT+UtAC8qxb3xAnGzukEHs0Pj/X+WBLpJOC36Ov4frlRcx2okIs+EaCMNBXwUi5X GAUwODuA10DbjpvhxyxFDDgbbL+fJ5beY5YAMcLCZ5tS7Q5qq5820lSuQ6n8Vx3qhEG1 jDFLkrGBwZO2+Q3L/SgcZH27Spa1m2LxSJQKVUciHtgZ2N68V1obUqqP8nNF0WsAz3oj 9Lzy4xugqVhiewxbWPkbMmVB6luwGaZebUexXHHrw6f3P5/IHrKW/1jx0TSqyTq5mtaC cIJw== X-Gm-Message-State: AOJu0YzPX31TqPQ7x0nL8lm0E+HVqcgVHrPDosfTECXm0rOTP3vfJywG yv6dFlBWcfw+aCq50z+BLLU2bYMnNzaNchtCh7Ygm9RX X-Google-Smtp-Source: AGHT+IFRu88w7/+X7VNfZRV22nUbtRpI1zSFkhO/N1g0etOxNqeimc6H/jQMCQ0MutUIlZiF+sGHGg== X-Received: by 2002:ac2:5b50:0:b0:4fb:92df:a27c with SMTP id i16-20020ac25b50000000b004fb92dfa27cmr547371lfp.25.1691731240148; Thu, 10 Aug 2023 22:20:40 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id bf20-20020a0564021a5400b0051d9dbf5edfsm1589558edb.55.2023.08.10.22.20.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Aug 2023 22:20:40 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-52340d9187aso1967390a12.3 for ; Thu, 10 Aug 2023 22:20:39 -0700 (PDT) X-Received: by 2002:aa7:c382:0:b0:523:22f6:e8a5 with SMTP id k2-20020aa7c382000000b0052322f6e8a5mr817276edq.39.1691731239420; Thu, 10 Aug 2023 22:20:39 -0700 (PDT) MIME-Version: 1.0 References: <20230626214656.hcp4puionmtoloat@moria.home.lan> <20230706155602.mnhsylo3pnief2of@moria.home.lan> <20230712025459.dbzcjtkb4zem4pdn@moria.home.lan> <20230810155453.6xz2k7f632jypqyz@moria.home.lan> <20230810223942.GG11336@frogsfrogsfrogs> <20230811040310.c3q6nml6ukwtw3j5@moria.home.lan> In-Reply-To: <20230811040310.c3q6nml6ukwtw3j5@moria.home.lan> From: Linus Torvalds Date: Thu, 10 Aug 2023 22:20:22 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] bcachefs To: Kent Overstreet Cc: "Darrick J. Wong" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-bcachefs@vger.kernel.org, dchinner@redhat.com, sandeen@redhat.com, willy@infradead.org, josef@toxicpanda.com, tytso@mit.edu, bfoster@redhat.com, jack@suse.cz, andreas.gruenbacher@gmail.com, brauner@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, dhowells@redhat.com, snitzer@kernel.org, axboe@kernel.dk Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 10 Aug 2023 at 21:03, Kent Overstreet wrote: > > On Thu, Aug 10, 2023 at 04:47:22PM -0700, Linus Torvalds wrote: > > So I might be barking up entirely the wrong tree. > > Yeah, I think you are, it sounds like you're describing an entirely > different sort of race. I was just going by Darrick's description of what he saw, which *seemed* to be that umount had finished with stuff still active: "Here, umount exits before the filesystem is really torn down, and then mount fails because it can't get an exclusive lock on the device." But maybe I misunderstood, and the umount wasn't actually successful (ie "exits" may have been "failed with EBUSY")? So I was trying to figure out what could cause the behavior I thought Darrick was describing, which would imply a mnt_count issue. If it's purely "umount doesnt' succeed because the filesystem is still busy with cleanups", then things are much better. The mnt_count is nasty, if it's not that, we're actually much better off, and I'll be very happy to have misunderstood Darrick's case. Linus