From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15DF0C3B189 for ; Wed, 12 Feb 2020 00:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE7D920848 for ; Wed, 12 Feb 2020 00:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581467342; bh=k28PC+4ttbIdCRxj3eOx/mcr/adsEt7hpbcB83PrPeA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=vVSddCZNV/1a/F9CjUK/cmW7yuiuDUfvJ9Tj5Y/dIBmjUdSbeA24itk6Wqy6o2pAc Qbuh4a3autLVojqBmwbQqAhThX8YfsXc8ye7AYlic1K00Y7O4VBj4ugkZrgxbL5/vQ HH0i3EDWX/W9r9fsMb9QsvkU4UuNCmJ3Zpumjsz0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728098AbgBLA3C (ORCPT ); Tue, 11 Feb 2020 19:29:02 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:43768 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728025AbgBLA3B (ORCPT ); Tue, 11 Feb 2020 19:29:01 -0500 Received: by mail-lj1-f196.google.com with SMTP id a13so225965ljm.10 for ; Tue, 11 Feb 2020 16:28:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I1zwim5bENoBH/YJdV0JdFYomer3zhgdaL9VRFgFbmk=; b=a0mAJB8SfJ9gaZZHweS2NdfMYUd1WCE17SI7XP87C6+Ff2gIDBgABMTm1Kx1Nsg1HY 0ruUjl8AovwmwDeG0JrMTljpLYvq2f2NsCGILLfMorIKOj/gOtfvalctlgOMWWRjQ4hp XXLCJke+6ceL5jkjOhRCVzu1uXDQxR66FqD6c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I1zwim5bENoBH/YJdV0JdFYomer3zhgdaL9VRFgFbmk=; b=fNmsuif/tW177EoeQuOLX09DRRtCVHaYW+k0MRx5h1Mo+/65zXC7G7gyYYj/3jxt11 BTy5/psmbWDkLaP33nN+hY2kxIrOnBdpIzt/NEsXXuFFG/x5BwsTykAlhZfkatG158eh nnqqVKs2QmgZuNKfgL2UFAQOYjnzAJbA98elOog54bpMDNtNOYvrdHTbJZl+iDS+Wh+t kBkXbBygNW3wvYDjWPFH7Kh1QBGjkXQnj7gsA2CfGgcNl+bMDzWhEQXxFJE7Pyw34c3j sQWOYv0xpoDsMMMLVfN1GRIotqi0ORLk+sPBPrFtENSqrscftuhyL+/Mbv9A+DTqG/BR 7q3w== X-Gm-Message-State: APjAAAWabRI9DJguH083Mt07AnlMlPdinKxpMqoJ+trUECx3PIZ7DLxF iejnJ80NG+BpoaOgtcsB3AGy7D9jNz4= X-Google-Smtp-Source: APXvYqzf3mJWdvWaR7mGO3RAoqM9fhaFhOy3mE32e36GbfG6DYHcWByJHQtqWs3oK9391W/j6+Yemw== X-Received: by 2002:a2e:9dc3:: with SMTP id x3mr6073662ljj.257.1581467338426; Tue, 11 Feb 2020 16:28:58 -0800 (PST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com. [209.85.208.178]) by smtp.gmail.com with ESMTPSA id i19sm2591494lfj.17.2020.02.11.16.28.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2020 16:28:57 -0800 (PST) Received: by mail-lj1-f178.google.com with SMTP id d10so228397ljl.9 for ; Tue, 11 Feb 2020 16:28:57 -0800 (PST) X-Received: by 2002:a2e:88c5:: with SMTP id a5mr6018875ljk.201.1581467335909; Tue, 11 Feb 2020 16:28:55 -0800 (PST) MIME-Version: 1.0 References: <20200211175507.178100-1-hannes@cmpxchg.org> <29b6e848ff4ad69b55201751c9880921266ec7f4.camel@surriel.com> <20200211193101.GA178975@cmpxchg.org> <20200211154438.14ef129db412574c5576facf@linux-foundation.org> In-Reply-To: <20200211154438.14ef129db412574c5576facf@linux-foundation.org> From: Linus Torvalds Date: Tue, 11 Feb 2020 16:28:39 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU To: Andrew Morton Cc: Johannes Weiner , Rik van Riel , linux-fsdevel , Linux-MM , Linux Kernel Mailing List , Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Al Viro , kernel-team@fb.com Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 11, 2020 at 3:44 PM Andrew Morton wrote: > > Testing this will be a challenge, but the issue was real - a 7GB > highmem machine isn't crazy and I expect the inode has become larger > since those days. Hmm. I would say that in the intening years a 7GB highmem machine has indeed become crazy. It used to be something we kind of supported. But we really should consider HIGHMEM to be something that is on the deprecation list. In this day and age, there is no excuse for running a 32-bit kernel with lots of physical memory. And if you really want to do that, and have some legacy hardware with a legacy use case, maybe you should be using a legacy kernel. I'd personally be perfectly happy to start removing HIGHMEM support again. Linus