From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="L+9hVabP" Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 205DED5C for ; Wed, 29 Nov 2023 06:42:34 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-54b450bd014so4901529a12.3 for ; Wed, 29 Nov 2023 06:42:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1701268952; x=1701873752; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6w05lBhliqG02QD74yDtfVUAWC7biZGqwSccI+QzqRQ=; b=L+9hVabPSPZdeBOJqShj6iRPu8VIaNVjCBEn9hfzZcbeVhZD2TxRJpjtwn43P5j71K 3riUzQT8ydmz8lQvfqrJ2yMA+DDfCSppE888AafpurETPb9fjOE88nEyuIPhDQKDY40K Fe1PERK32x0b3lLXaaVEegl7WgUdSlUZeL9cg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701268952; x=1701873752; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6w05lBhliqG02QD74yDtfVUAWC7biZGqwSccI+QzqRQ=; b=q1RUuMSa1QoK+PDAghZuFIO+Nyk19zlWBM8lKVPDj+rV466PACeeAJ6fjFbleuFiNv /LapwqI2cn9XYY95ZYNHePYPRYufrLvxVfZqvS/pGUw/mWcOa47hoSeyr+JPL31ke/rs HnslzQTOsAAjKk9OOMSFtWm71fBAYCtBpJi9GfIEjthY8eXEudF937lmJpmL7Uv6yciD P8bxbcumZkZ/xNtDxxTJtmgutQgGKZRDO4B1IlSl7sy64aNk95Iv/vc68Aq6WWKD2lPp DOENo+gJir7En5qrO9LHcd+A1hKTG7i+J5QcKr/Qv41bdn+mGeGzPIOgvomT3KuCYID2 wzVg== X-Gm-Message-State: AOJu0YwXH1x0NHpMrOTKNzFnbyQwfqsLWpT7BF/TdzuqYyxKPJl23nCY QJtNZ2WwW9tlma+F8s9T/O46lToW8J8rmVchTItpwnau X-Google-Smtp-Source: AGHT+IGSjmoAhJybhOkEIX/F3Ywm3YKqniym2x37i5OEpWDDIIMG8hevgQciWqQarcgStD7cT1sT7w== X-Received: by 2002:a50:aaca:0:b0:545:4bf3:ac89 with SMTP id r10-20020a50aaca000000b005454bf3ac89mr14395499edc.23.1701268952369; Wed, 29 Nov 2023 06:42:32 -0800 (PST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id b19-20020a056402279300b0054b5d5248easm3575656ede.86.2023.11.29.06.42.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 06:42:31 -0800 (PST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a00cbb83c82so975238666b.2 for ; Wed, 29 Nov 2023 06:42:31 -0800 (PST) X-Received: by 2002:a17:906:70c8:b0:9e2:9647:9a54 with SMTP id g8-20020a17090670c800b009e296479a54mr11284943ejk.3.1701268950876; Wed, 29 Nov 2023 06:42:30 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231101062104.2104951-9-viro@zeniv.linux.org.uk> <20231101084535.GG1957730@ZenIV> <20231101181910.GH1957730@ZenIV> <20231110042041.GL1957730@ZenIV> In-Reply-To: From: Linus Torvalds Date: Wed, 29 Nov 2023 06:42:13 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: lockless case of retain_dentry() (was Re: [PATCH 09/15] fold the call of retain_dentry() into fast_dput()) To: Guo Ren Cc: Al Viro , Peter Zijlstra , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, 29 Nov 2023 at 04:25, Guo Ren wrote: > > > +#if defined(__LITTLE_ENDIAN) && BITS_PER_LONG == 64 > > + #define LOCKREF_ADD(n,x) ((n).lock_count += (unsigned long)(x)<<32) > > +#else > > + #define LOCKREF_ADD(n,x) ((n).count += (unsigned long)(x)<<32) > #define LOCKREF_ADD(n,x) ((n).count += (unsigned long)(x)) > ? Yes. I obviously only tested the little-endian case, and the BE case was a bit too much cut-and-paste.. Linus