From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7E9C43381 for ; Sat, 16 Mar 2019 01:49:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2C3A218D0 for ; Sat, 16 Mar 2019 01:49:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552700969; bh=rhucAxpADybmaOTkPe42dRghha6wO96JTN4OiIzVN2s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=LEoeIu9qH5eGbIHTNwJhdvkwhYkItwywBYY6Oqio++tXWvANMvaY3GKTcZR96d9k/ PQ4VSwiXnlUU4fV2E1QwDZbFc21kL7TQv09fZsjF68K7LwaafT5EG0Er7SbmNXrkSz VuQE/UOafEuNqh+BhjYs7xnJ0laRJJsoZTXsHy5g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726638AbfCPBt2 (ORCPT ); Fri, 15 Mar 2019 21:49:28 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:41740 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbfCPBt2 (ORCPT ); Fri, 15 Mar 2019 21:49:28 -0400 Received: by mail-lj1-f195.google.com with SMTP id z25so9502351ljk.8 for ; Fri, 15 Mar 2019 18:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YZ9keLsoqxizG4n/mz6mPuOXvZiAzBcHeRDiG3bZ3Co=; b=bjkCi4EKnUp8bAyLsgwmj7BrMch8NGHoP1r9iBpN9YpUEvT4ZjDyGXiC8bSM9Eb9kn a9j83yJ1gl3YjFUoKWPVB2wXdW3WvonvUb4+f/xq8Zvstma9jWySH6m6U4MrR03JDGlJ IegkzZD5U73Dhgqnq+90gitb3ckswhcYm6/eQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YZ9keLsoqxizG4n/mz6mPuOXvZiAzBcHeRDiG3bZ3Co=; b=T7kv8Y24E8TEi5gFD++57tMztIO6MT8aMfqEVDtnxR637d6DjShMVdYGC60Zj43jIv fHT++Lkw3xwX2RqmHY0lAMB8sbt/gKfN6AgIs6wdx2J/BgtXL7Ue0/uGqiEg1aYDG5mE qQKdc14yDemeWh2w14OkLCtY/G8IhAQS2BIBWAP30TSILNjqBp+bXoES6dEd7t46OZ+x vavkOJREbZhF7U39yRtFeFbPxJg62IeptC8jMMwcqmON09tJOKD3DnV9uM85S0DhGijE /H3AmvD+QwT4M0wczFPCCxGU5Bb1PAVbZsGRt6YPf7X9EK9eBXWBRShxqkYoEvt0d9cA YWjw== X-Gm-Message-State: APjAAAVq4J329lhgBPqI1oDs1jMgDpSK1cMoICyYXo4Z1oOB5khQXgmr tN2QtNUX5Bf5+n6jfoWajqsCbSnqYSs= X-Google-Smtp-Source: APXvYqwmA1/k7fqIBmvhs4hE+TkEGGk99PzjJTIj23hDSsr0PiF7vyr7lF+m0c7ukuL5JHh3e9vV8g== X-Received: by 2002:a2e:8456:: with SMTP id u22mr3665682ljh.108.1552700966338; Fri, 15 Mar 2019 18:49:26 -0700 (PDT) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com. [209.85.167.52]) by smtp.gmail.com with ESMTPSA id u14sm717566lfu.94.2019.03.15.18.49.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 18:49:25 -0700 (PDT) Received: by mail-lf1-f52.google.com with SMTP id u2so8106265lfd.4 for ; Fri, 15 Mar 2019 18:49:25 -0700 (PDT) X-Received: by 2002:ac2:548f:: with SMTP id t15mr3830644lfk.166.1552700965063; Fri, 15 Mar 2019 18:49:25 -0700 (PDT) MIME-Version: 1.0 References: <12246.1552693296@warthog.procyon.org.uk> In-Reply-To: <12246.1552693296@warthog.procyon.org.uk> From: Linus Torvalds Date: Fri, 15 Mar 2019 18:49:08 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] AFS fixes and other bits To: David Howells Cc: linux-afs@lists.infradead.org, linux-fsdevel , Linux List Kernel Mailing Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Mar 15, 2019 at 4:41 PM David Howells wrote: > > Here's a set of fixes and other bits for AFS to improve the life of desktop > applications such as firefox. I pulled, and immediately unpulled. The thing hasn't even seen a compiler, and when you *do* show the code to a compiler, said compiler correctly warns about afs_do_silly_unlink() potentially returning an uninitialized variable. And yes, it's _trivially_ and obviously uninitialized. Feel free to submit this for 5.2 after it has actually seen testing. But this late in the 5.1 merge window, I'm no longer interested in totally untested new crap. It clearly wasn't ready before the merge window, and it clearly isn't ready *now*. Much too late to try to fix this up, Linus