linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH stable 0/5] Fix missing patches in stable
Date: Thu, 27 Oct 2022 16:15:52 +0200	[thread overview]
Message-ID: <CAHmME9r9NRATt5YsApkTRBQtXCDGCkCZO9TPtyk9Oi9BUcyw5A@mail.gmail.com> (raw)
In-Reply-To: <20221017192006.36398-1-saeed.mirzamohammadi@oracle.com>

On Mon, Oct 17, 2022 at 9:20 PM Saeed Mirzamohammadi
<saeed.mirzamohammadi@oracle.com> wrote:
>
> The following patches has been applied to 6.0 but only patch#2 below
> has been applied to stable. This caused regression with nfs tests in
> all stable releases.
>
> This patchset backports patches 1 and 3-6 to stable.
>
> 1. 868941b14441 fs: remove no_llseek
> 2. 97ef77c52b78 fs: check FMODE_LSEEK to control internal pipe splicing
> 3. 54ef7a47f67d vfio: do not set FMODE_LSEEK flag
> 4. c9eb2d427c1c dma-buf: remove useless FMODE_LSEEK flag
> 5. 4e3299eaddff fs: do not compare against ->llseek
> 6. e7478158e137 fs: clear or set FMODE_LSEEK based on llseek function
>
> For 5.10.y and 5.4.y only, a revert of patch#2 is already included.
> Please apply patch#2, for 5.4.y and 5.10.y as well.

This is confusing and there's no way Greg is going to do this right
given the limited information you've provided and wrong ordering of
the patches. I couldn't really even follow this without some detective
work, and I wrote these patches.

Here are your options:
- Let the revert of "97ef77c52b78 fs: check FMODE_LSEEK to control
internal pipe splicing" work its way into all stable trees; or
- Send a proper backport series for each and every stable kernel,
depending on what each one needs. Send these as different patchsets,
marked with the version number it applies to. Make sure they apply,
compile, and work correctly.

Anything short of those is going to lead to chaos.

Jason

      parent reply	other threads:[~2022-10-27 14:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 19:20 [PATCH stable 0/5] Fix missing patches in stable Saeed Mirzamohammadi
2022-10-17 19:20 ` [PATCH stable 1/5] fs: clear or set FMODE_LSEEK based on llseek function Saeed Mirzamohammadi
2022-10-17 19:20 ` [PATCH stable 2/5] fs: do not compare against ->llseek Saeed Mirzamohammadi
2022-10-17 19:20 ` [PATCH stable 3/5] dma-buf: remove useless FMODE_LSEEK flag Saeed Mirzamohammadi
2022-10-17 19:20 ` [PATCH stable 4/5] vfio: do not set " Saeed Mirzamohammadi
2022-10-17 19:20 ` [PATCH stable 5/5] fs: remove no_llseek Saeed Mirzamohammadi
2022-10-26 16:58 ` [PATCH stable 0/5] Fix missing patches in stable Greg KH
2022-10-27 14:15 ` Jason A. Donenfeld [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHmME9r9NRATt5YsApkTRBQtXCDGCkCZO9TPtyk9Oi9BUcyw5A@mail.gmail.com \
    --to=jason@zx2c4.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saeed.mirzamohammadi@oracle.com \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).