Re: [PATCH v9 11/19] scsi: sd: Translate data lifetime information

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Wed, Jun 12, 2024 at 2:08 AM Bart Van Assche <bvanassche@acm.org> wrote:
> On 6/11/24 2:21 PM, Christian Heusel wrote:
> > On 24/06/11 11:57PM, Andy Shevchenko wrote:
> >> Tue, Jan 30, 2024 at 01:48:37PM -0800, Bart Van Assche kirjoitti:
> >>> Recently T10 standardized SBC constrained streams. This mechanism allows
> >>> to pass data lifetime information to SCSI devices in the group number
> >>> field. Add support for translating write hint information into a
> >>> permanent stream number in the sd driver. Use WRITE(10) instead of
> >>> WRITE(6) if data lifetime information is present because the WRITE(6)
> >>> command does not have a GROUP NUMBER field.
> >>
> >> This patch broke very badly my connected Garmin FR35 sport watch. The boot time
> >> increased by 1 minute along with broken access to USB mass storage.
> >>
> >> On the reboot it takes ages as well.
> >>
> >> Revert of this and one little dependency (unrelated by functional means) helps.
> >
> > We have tested that the revert fixes the issue on top of v6.10-rc3.
> >
> > Also adding the regressions list in CC and making regzbot aware of this
> > issue.
> >
> >> Details are here: https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/issues/60
> >>
> >> P.S. Big thanks to Arch Linux team to help with bisection!
> >
> > If this is fixed adding in a "Reported-by" or "Bisected-by" (depending
> > on what this subsystem uses) for me would be appreciated :)
>
> Thank you Christian for having gone through the painful process of
> bisecting this issue.

> Is the Garmin FR35 Flash device perhaps connected to a USB bus? If so,

Yes. It is written above in my report here.

> this is the second report of a USB storage device that resets if it
> receives a query for the IO Advice Hints Grouping mode page. Does the
> patch below help?

I tested the kernel build from
https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/issues/60#note_190857
which claims to have this fix and it fixes my issue.

Reported-and-tested-by: Andy Shevchenko <andy.shevchenko@gmail.com>

P.S. And please add any suitable tag for Christian, thank you!

-- 
With Best Regards,
Andy Shevchenko