From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-wm0-f43.google.com ([74.125.82.43]:37327 "EHLO
	mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756055AbbLAKa0 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Dec 2015 05:30:26 -0500
MIME-Version: 1.0
In-Reply-To: <alpine.LRH.2.20.1512012052110.15599@namei.org>
References: <1448919823-27103-1-git-send-email-agruenba@redhat.com>
	<1448919823-27103-11-git-send-email-agruenba@redhat.com>
	<alpine.LRH.2.20.1512012052110.15599@namei.org>
Date: Tue, 1 Dec 2015 11:30:25 +0100
Message-ID: <CAHpGcMLwp+=ry69iAVq2kS4O+h2z+hes7KWH8XCAmSn0c4Fhfg@mail.gmail.com>
Subject: Re: [PATCH 10/10] xattr handlers: Simplify list operation
From: =?UTF-8?Q?Andreas_Gr=C3=BCnbacher?= <andreas.gruenbacher@gmail.com>
To: James Morris <jmorris@namei.org>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

2015-12-01 10:53 GMT+01:00 James Morris <jmorris@namei.org>:
> On Mon, 30 Nov 2015, Andreas Gruenbacher wrote:
>
>> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
>> index 906022d..61dd93f 100644
>> --- a/fs/ocfs2/xattr.c
>> +++ b/fs/ocfs2/xattr.c
>> @@ -895,6 +895,8 @@ static int ocfs2_xattr_list_entry(char *buffer, size_t size,
>>
>>       *result += total_len;
>>
>> +     /* FIXME: Not checking the ->list operation here ... */
>> +
>
> What does this mean?

ocfs2 defines list xattr handler operations for "user.*" and
"trusted.*" xattrs but never bothers calling them. Should be fixed
separately.

Thanks,
Andreas