linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Hanna Czenczek <hreitz@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-doc@vger.kernel.org, virtualization@lists.linux.dev,
	"Miklos Szeredi" <mszeredi@redhat.com>,
	"German Maglione" <gmaglione@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: [PATCH 0/2] virtio-fs: Add 'file' mount option
Date: Thu, 29 Aug 2024 15:07:05 +0200	[thread overview]
Message-ID: <CAJfpegs0Y3bmsw3jThaV+PboQEsWWoQYBLZwkqx9sLMAdqCa6Q@mail.gmail.com> (raw)
In-Reply-To: <19017a78-b14a-4998-8ebb-f3ffdbfae5b8@redhat.com>

On Thu, 29 Aug 2024 at 14:37, Hanna Czenczek <hreitz@redhat.com> wrote:

> I honestly have no idea how to go about it on a technical level,
> though.  Naïvely, I think we’d need to split off the tail of
> fuse_fill_super_common() (everything starting from the
> fuse_get_root_inode() call) into a separate function, which in case of
> virtio-fs we’d call once we get the FUSE_INIT reply.  (For
> non-virtio-fs, we could just call it immediately after
> fuse_fill_super_common().)

Yes, except I'm not sure it needs to be split, that depends on whether
sending a request relies on any initialization in that function or
not.

> But we can’t return from fuse_fill_super() until that root node is set
> up, can we?  If so, we‘d need to await that FUSE_INIT reply in that
> function.  Can we do that?

Sure, just need to send FUSE_INIT with fuse_simple_request() instead
of fuse_simple_background().

Thanks,
Miklos

  reply	other threads:[~2024-08-29 13:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 11:19 [PATCH 0/2] virtio-fs: Add 'file' mount option Hanna Czenczek
2024-07-09 11:19 ` [PATCH 1/2] " Hanna Czenczek
2024-07-09 11:19 ` [PATCH 2/2] virtio-fs: Document " Hanna Czenczek
2024-07-09 17:56 ` [PATCH 0/2] virtio-fs: Add " Josef Bacik
2024-07-10  7:28   ` Hanna Czenczek
2024-07-10 18:42     ` Josef Bacik
2024-07-11  8:21       ` Hanna Czenczek
2024-07-11 14:27         ` Hanna Czenczek
2024-07-11 14:34         ` Josef Bacik
2024-07-11 15:04           ` Hanna Czenczek
2024-07-10 17:28 ` Stefan Hajnoczi
2024-07-11  8:31   ` Hanna Czenczek
2024-08-29  8:07 ` Miklos Szeredi
2024-08-29 12:37   ` Hanna Czenczek
2024-08-29 13:07     ` Miklos Szeredi [this message]
     [not found]       ` <b82dd5f9-a214-4a13-b500-38b07f1e9761@redhat.com>
2024-08-29 13:21         ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegs0Y3bmsw3jThaV+PboQEsWWoQYBLZwkqx9sLMAdqCa6Q@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=corbet@lwn.net \
    --cc=eperezma@redhat.com \
    --cc=gmaglione@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=vgoyal@redhat.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).