linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Bernd Schubert <bschubert@ddn.com>,
	linux-fsdevel@vger.kernel.org, dsingh@ddn.com
Subject: Re: [PATCH v2 4/5] fuse: prepare for failing open response
Date: Thu, 1 Feb 2024 11:51:21 +0100	[thread overview]
Message-ID: <CAJfpegs4hQg93Dariy5hz4bsxiFKoRuLsB5aRO4S6iiu6_DAKw@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxiXEc-p7JY03RH2hJg7d+R1EtwGdBowTkOuaT9Ps_On8Q@mail.gmail.com>

On Thu, 1 Feb 2024 at 11:41, Amir Goldstein <amir73il@gmail.com> wrote:

> I was considering splitting fuse_finish_open() to the first part that
> can fail and the "finally" part that deals with attributes, but seeing
> that this entire chunk of atomic_o_trunc code in fuse_finish_open()
> is never relevant to atomic_open(), I'd rather just move it out
> into fuse_open_common() which has loads of other code related to
> atomic_o_trunc anyway?

Yep.

Thanks,
Miklos

  reply	other threads:[~2024-02-01 10:51 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 23:08 [PATCH v2 0/5] fuse: inode IO modes and mmap Bernd Schubert
2024-01-31 23:08 ` [PATCH v2 1/5] fuse: Fix VM_MAYSHARE and direct_io_allow_mmap Bernd Schubert
2024-02-01  8:45   ` Miklos Szeredi
2024-02-01 14:36     ` Bernd Schubert
2024-02-01 14:52       ` Miklos Szeredi
2024-02-01 15:39         ` Bernd Schubert
2024-02-01 15:43           ` Miklos Szeredi
2024-02-01 15:48             ` Amir Goldstein
2024-02-01 16:16               ` Bernd Schubert
2024-02-02 14:47             ` Bernd Schubert
2024-01-31 23:08 ` [PATCH v2 2/5] fuse: Create helper function if DIO write needs exclusive lock Bernd Schubert
2024-02-06  9:20   ` Jingbo Xu
2024-02-07 13:38     ` Bernd Schubert
2024-02-07 13:44       ` Jingbo Xu
2024-02-07 14:13         ` Bernd Schubert
2024-02-08  0:04           ` Jingbo Xu
2024-01-31 23:08 ` [PATCH v2 3/5] fuse: Add fuse_dio_lock/unlock helper functions Bernd Schubert
2024-01-31 23:08 ` [PATCH v2 4/5] fuse: prepare for failing open response Bernd Schubert
2024-02-01  9:23   ` Miklos Szeredi
2024-02-01 10:16     ` Amir Goldstein
2024-02-01 10:28       ` Miklos Szeredi
2024-02-01 10:41         ` Amir Goldstein
2024-02-01 10:51           ` Miklos Szeredi [this message]
2024-02-01 16:46             ` Amir Goldstein
2024-02-02 12:03               ` Amir Goldstein
2024-02-02 15:49                 ` Miklos Szeredi
2024-02-02 15:55   ` Miklos Szeredi
2024-02-02 16:07     ` Amir Goldstein
2024-01-31 23:08 ` [PATCH v2 5/5] fuse: introduce inode io modes Bernd Schubert
2024-02-01 14:47   ` Miklos Szeredi
2024-02-01 16:33     ` Amir Goldstein
2024-02-01 17:53       ` Bernd Schubert
2024-02-02 19:40         ` Amir Goldstein
2024-02-06 12:39       ` Amir Goldstein
2024-02-06 12:53         ` Miklos Szeredi
2024-02-06 13:07           ` Amir Goldstein
2024-02-01 10:30 ` [PATCH v2 0/5] fuse: inode IO modes and mmap Amir Goldstein
2024-02-01 14:30   ` Bernd Schubert
2024-02-01 15:56     ` Amir Goldstein
2024-02-01 16:01       ` Bernd Schubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegs4hQg93Dariy5hz4bsxiFKoRuLsB5aRO4S6iiu6_DAKw@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=bschubert@ddn.com \
    --cc=dsingh@ddn.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).