From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: overlayfs <linux-unionfs@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Stefan Agner <stefan@agner.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <levinsasha928@gmail.com>
Subject: Re: WARNING: possible recursive locking detected in mnt_want_write/mnt_want_write_file_path
Date: Wed, 17 Oct 2018 20:37:11 +0200 [thread overview]
Message-ID: <CAJfpegsAvjfixdO9iRDsV2XwvGaQS9GpbBdkKnkxJS=3ghcZ-g@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxgcsHXZ3ctE1NNMey_y_LNagtx_n+Tdq7SApT6EgLsd0Q@mail.gmail.com>
On Wed, Oct 17, 2018 at 5:24 PM, Amir Goldstein <amir73il@gmail.com> wrote:
> On Wed, Oct 17, 2018 at 11:29 AM Miklos Szeredi <miklos@szeredi.hu> wrote:
>>
>> Cc: linux-unionfs@vger
>>
>> On Wed, Oct 17, 2018 at 10:00 AM, Stefan Agner <stefan@agner.ch> wrote:
>> > Hi,
>> >
>> > I noticed this warning since we moved to 4.18. It appears when
>> > using Docker (which uses overlayfs). Is this a known issue?
>> >
>> > [ 543.235366] WARNING: possible recursive locking detected
>> > [ 543.240747] 4.18.14 #1 Not tainted
>> > [ 543.244195] --------------------------------------------
>> > [ 543.249573] dockerd/522 is trying to acquire lock:
>> > [ 543.254426] 86b0f89c (sb_writers#7){.+.+}, at: mnt_want_write+0x20/0x4c
>> > [ 543.261152] but task is already holding lock:
>> > [ 543.267053] 86b0f89c (sb_writers#7){.+.+}, at: mnt_want_write_file_path+0x24/0x54
>> > [ 543.274641] other info that might help us debug this:
>> > [ 543.281242] Possible unsafe locking scenario:
>> > [ 543.287227] CPU0
>> > [ 543.289706] ----
>> > [ 543.292183] lock(sb_writers#7);
>> > [ 543.295547] lock(sb_writers#7);
>> > [ 543.298912] *** DEADLOCK ***
>> > [ 543.306825] May be due to missing lock nesting notation
>> > [ 543.315594] 2 locks held by dockerd/522:
>> > [ 543.320487] #0: 86b0f89c (sb_writers#7){.+.+}, at: mnt_want_write_file_path+0x24/0x54
>> > [ 543.330353] #1: fbe4681b (&ovl_i_mutex_key[depth]){+.+.}, at: chown_common+0xf8/0x1c0
>
> This is a stable tree regression because upstream commit
> a6795a585929 vfs: fix freeze protection in mnt_want_write_file() for overlayfs
>
> SHOULD NOT have been applied to kernel <= 4.18
>
> Miklos,
>
> You must have confused "the algorithm" by including a "fix" commit in
> rc1 pull request
> without mentioning that it "Fixes" a commit in the same pull request.
I didn't know there were heuristics other than "Cc: stable@.."
> It probably didn't help that the commit applied cleanly to the wrong
> function :-/
Heh...
Thanks,
Miklos
next prev parent reply other threads:[~2018-10-17 18:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 8:00 WARNING: possible recursive locking detected in mnt_want_write/mnt_want_write_file_path Stefan Agner
2018-10-17 8:29 ` Miklos Szeredi
2018-10-17 15:24 ` Amir Goldstein
2018-10-17 16:03 ` Sasha Levin
2018-10-17 18:37 ` Miklos Szeredi [this message]
2018-10-18 11:50 ` Amir Goldstein
2018-10-18 13:25 ` Stefan Agner
2018-10-18 14:34 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegsAvjfixdO9iRDsV2XwvGaQS9GpbBdkKnkxJS=3ghcZ-g@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=stefan@agner.ch \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).