linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: djwong@kernel.org, willy@infradead.org,
	linux-fsdevel@vger.kernel.org,  kernel-team@meta.com
Subject: Re: [PATCH v1 1/2] fuse: disallow dynamic inode blksize changes
Date: Tue, 5 Aug 2025 07:11:06 +0200	[thread overview]
Message-ID: <CAJfpegsH6TEQO_Cbj5Tc7z_dYTfnE42rpi13HrfA0WbRmWs-=A@mail.gmail.com> (raw)
In-Reply-To: <20250804210743.1239373-2-joannelkoong@gmail.com>

On Mon, 4 Aug 2025 at 23:10, Joanne Koong <joannelkoong@gmail.com> wrote:
>
> With fuse using iomap, which relies on inode->i_blkbits for its internal
> bitmap tracking, disallow fuse servers from dynamically changing the
> inode blocksize.
>
> "attr->blksize = sx->blksize;" is retained in fuse_statx_to_attr() so
> that any attempts by the server to change the blksize through the statx
> reply is surfaced to dmesg.

I expect no big breakage, but I'm quite sure that message will scare
some people for no good reason.  I'd just keep a copy of attr->blksize
in fuse_inode and present that in stx_blksize, while keeping the
internal i_blkbits consistent.

Thoughts?

Thanks,
Miklos

  reply	other threads:[~2025-08-05  5:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 21:07 [PATCH v1 0/2] fuse: disallow dynamic inode blksize changes Joanne Koong
2025-08-04 21:07 ` [PATCH v1 1/2] " Joanne Koong
2025-08-05  5:11   ` Miklos Szeredi [this message]
2025-08-05 20:40     ` Joanne Koong
2025-08-04 21:07 ` [PATCH v1 2/2] fuse: add blksize configuration at mount for non-fuseblk servers Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegsH6TEQO_Cbj5Tc7z_dYTfnE42rpi13HrfA0WbRmWs-=A@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=djwong@kernel.org \
    --cc=joannelkoong@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).