From: Miklos Szeredi <miklos@szeredi.hu>
To: Miklos Szeredi <miklos@szeredi.hu>,
fuse-devel <fuse-devel@lists.sourceforge.net>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [fuse-devel] Handling of 32/64 bit off_t by getdents64()
Date: Thu, 28 Nov 2019 08:42:33 +0100 [thread overview]
Message-ID: <CAJfpegsZBLZ=w_tsk8AzV-kcmu0_PpfP86G9tuEnyuP+-19r-Q@mail.gmail.com> (raw)
In-Reply-To: <87muchyrct.fsf@vostro.rath.org>
On Wed, Nov 27, 2019 at 9:52 PM Nikolaus Rath <Nikolaus@rath.org> wrote:
>
> On Nov 27 2019, Miklos Szeredi <miklos@szeredi.hu> wrote:
> >> Is there a way for a 64 bit process (in this case the FUSE daemon) to
> >> ask for 32 bit d_off values from getdents64()?
> >
> > Looking at ext4 d_off encoding, it looks like the simple workaround is
> > to use the *high* 32 bits of the offset.
> >
> > Just tried, and this works. The lower bits are the "minor" number of
> > the offset, and no issue with zeroing those bits out, other than
> > increasing the chance of hash collision from practically zero to very
> > close to zero.
> >
> >> Would it be feasible to extend the FUSE protocol to include information
> >> about the available bits in d_off?
> >
> > Yes.
> >
> > The relevant bits from ext4 are:
> >
> > static inline int is_32bit_api(void)
> > {
> > #ifdef CONFIG_COMPAT
> > return in_compat_syscall();
> > #else
> > return (BITS_PER_LONG == 32);
> > #endif
> > }
>
> Thanks for the quick response!
>
> Is there a way to do the same without relying on ext4 internals, i.e. by
> manually calling getdents64() in such a way that in_compat_syscall()
> gives true even if the caller is 64 bit?
Generally that's not doable. Might be able to do a 32bit syscall
specifically on x86_64, but I don't know the details.
Thanks,
Miklos
prev parent reply other threads:[~2019-11-28 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 9:33 Handling of 32/64 bit off_t by getdents64() Nikolaus Rath
2019-11-27 14:30 ` Miklos Szeredi
2019-11-27 20:52 ` [fuse-devel] " Nikolaus Rath
2019-11-28 7:42 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegsZBLZ=w_tsk8AzV-kcmu0_PpfP86G9tuEnyuP+-19r-Q@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).