From: Miklos Szeredi <miklos@szeredi.hu>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm,
jlayton@kernel.org, jefflexu@linux.alibaba.com,
josef@toxicpanda.com, kernel-team@meta.com,
Bernd Schubert <bschubert@ddn.com>
Subject: Re: [PATCH v6 01/11] fuse: support copying large folios
Date: Fri, 16 May 2025 11:47:22 +0200 [thread overview]
Message-ID: <CAJfpegsiSEfs-i-uZ-RJu7ZaQ0+HWvbTDonzBJHgGP8YuB_e1w@mail.gmail.com> (raw)
In-Reply-To: <CAJnrk1aVcT5ZWT-KgrThQ4jxnd0=AvTggvE0CbaMG+9zOFxfZA@mail.gmail.com>
On Thu, 15 May 2025 at 19:54, Joanne Koong <joannelkoong@gmail.com> wrote:
> I think this needs to be:
>
> if (folio) {
> void *mapaddr = kmap_local_folio(folio, offset);
> void *buf = mapaddr;
> unsigned copy = count;
> unsigned bytes_copied;
>
> if (folio_test_highmem(folio) && count >
> PAGE_SIZE - offset_in_page(offset))
> copy = PAGE_SIZE - offset_in_page(offset);
>
> bytes_copied = fuse_copy_do(cs, &buf, ©);
> kunmap_local(mapaddr);
> offset += bytes_copied;
> count -= bytes_copied;
>
> else it will only copy the first page of the highmem folio.
Right. Fix applied.
Thanks,
Miklos
next prev parent reply other threads:[~2025-05-16 9:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-12 22:58 [PATCH v6 00/11] fuse: support large folios Joanne Koong
2025-05-12 22:58 ` [PATCH v6 01/11] fuse: support copying " Joanne Koong
2025-05-14 0:18 ` Matthew Wilcox
2025-05-14 22:59 ` Joanne Koong
2025-05-15 2:05 ` Matthew Wilcox
2025-05-15 18:50 ` Joanne Koong
2025-05-15 8:26 ` Miklos Szeredi
2025-05-15 17:53 ` Joanne Koong
2025-05-16 9:47 ` Miklos Szeredi [this message]
2025-05-12 22:58 ` [PATCH v6 02/11] fuse: support large folios for retrieves Joanne Koong
2025-05-12 22:58 ` [PATCH v6 03/11] fuse: refactor fuse_fill_write_pages() Joanne Koong
2025-05-12 22:58 ` [PATCH v6 04/11] fuse: support large folios for writethrough writes Joanne Koong
2025-05-12 22:58 ` [PATCH v6 05/11] fuse: support large folios for folio reads Joanne Koong
2025-05-12 22:58 ` [PATCH v6 06/11] fuse: support large folios for symlinks Joanne Koong
2025-05-12 22:58 ` [PATCH v6 07/11] fuse: support large folios for stores Joanne Koong
2025-05-12 22:58 ` [PATCH v6 08/11] fuse: support large folios for queued writes Joanne Koong
2025-05-12 22:58 ` [PATCH v6 09/11] fuse: support large folios for readahead Joanne Koong
2025-05-12 22:58 ` [PATCH v6 10/11] fuse: optimize direct io large folios processing Joanne Koong
2025-05-13 7:19 ` Miklos Szeredi
2025-05-13 20:39 ` Joanne Koong
2025-05-15 8:27 ` Miklos Szeredi
2025-05-12 22:58 ` [PATCH v6 11/11] fuse: support large folios for writeback Joanne Koong
2025-05-13 7:32 ` [PATCH v6 00/11] fuse: support large folios Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegsiSEfs-i-uZ-RJu7ZaQ0+HWvbTDonzBJHgGP8YuB_e1w@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=bernd.schubert@fastmail.fm \
--cc=bschubert@ddn.com \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).