* [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs
@ 2022-06-10 2:08 Deming Wang
2022-06-15 13:54 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Deming Wang @ 2022-06-10 2:08 UTC (permalink / raw)
To: vgoyal, stefanha, miklos
Cc: virtualization, linux-fsdevel, linux-kernel, Deming Wang
fs parameter not used. So, it needs to be deleted.
Signed-off-by: Deming Wang <wangdeming@inspur.com>
---
fs/fuse/virtio_fs.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 8db53fa67359..0991199d19c1 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -741,8 +741,7 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
}
/* Free virtqueues (device must already be reset) */
-static void virtio_fs_cleanup_vqs(struct virtio_device *vdev,
- struct virtio_fs *fs)
+static void virtio_fs_cleanup_vqs(struct virtio_device *vdev)
{
vdev->config->del_vqs(vdev);
}
@@ -895,7 +894,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
out_vqs:
virtio_reset_device(vdev);
- virtio_fs_cleanup_vqs(vdev, fs);
+ virtio_fs_cleanup_vqs(vdev);
kfree(fs->vqs);
out:
@@ -927,7 +926,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
virtio_fs_stop_all_queues(fs);
virtio_fs_drain_all_queues_locked(fs);
virtio_reset_device(vdev);
- virtio_fs_cleanup_vqs(vdev, fs);
+ virtio_fs_cleanup_vqs(vdev);
vdev->priv = NULL;
/* Put device reference on virtio_fs object */
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs
2022-06-10 2:08 [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs Deming Wang
@ 2022-06-15 13:54 ` Stefan Hajnoczi
2022-06-15 17:57 ` Vivek Goyal
2022-07-18 14:02 ` Miklos Szeredi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2022-06-15 13:54 UTC (permalink / raw)
To: Deming Wang; +Cc: vgoyal, miklos, virtualization, linux-fsdevel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 323 bytes --]
On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
> ---
> fs/fuse/virtio_fs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs
2022-06-10 2:08 [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs Deming Wang
2022-06-15 13:54 ` Stefan Hajnoczi
@ 2022-06-15 17:57 ` Vivek Goyal
2022-07-18 14:02 ` Miklos Szeredi
2 siblings, 0 replies; 4+ messages in thread
From: Vivek Goyal @ 2022-06-15 17:57 UTC (permalink / raw)
To: Deming Wang; +Cc: stefanha, miklos, virtualization, linux-fsdevel, linux-kernel
On Thu, Jun 09, 2022 at 10:08:38PM -0400, Deming Wang wrote:
> fs parameter not used. So, it needs to be deleted.
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
Thanks Deming Wang for the patch. Good cleanup.
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Thanks
Vivek
> ---
> fs/fuse/virtio_fs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 8db53fa67359..0991199d19c1 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -741,8 +741,7 @@ static int virtio_fs_setup_vqs(struct virtio_device *vdev,
> }
>
> /* Free virtqueues (device must already be reset) */
> -static void virtio_fs_cleanup_vqs(struct virtio_device *vdev,
> - struct virtio_fs *fs)
> +static void virtio_fs_cleanup_vqs(struct virtio_device *vdev)
> {
> vdev->config->del_vqs(vdev);
> }
> @@ -895,7 +894,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
>
> out_vqs:
> virtio_reset_device(vdev);
> - virtio_fs_cleanup_vqs(vdev, fs);
> + virtio_fs_cleanup_vqs(vdev);
> kfree(fs->vqs);
>
> out:
> @@ -927,7 +926,7 @@ static void virtio_fs_remove(struct virtio_device *vdev)
> virtio_fs_stop_all_queues(fs);
> virtio_fs_drain_all_queues_locked(fs);
> virtio_reset_device(vdev);
> - virtio_fs_cleanup_vqs(vdev, fs);
> + virtio_fs_cleanup_vqs(vdev);
>
> vdev->priv = NULL;
> /* Put device reference on virtio_fs object */
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs
2022-06-10 2:08 [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs Deming Wang
2022-06-15 13:54 ` Stefan Hajnoczi
2022-06-15 17:57 ` Vivek Goyal
@ 2022-07-18 14:02 ` Miklos Szeredi
2 siblings, 0 replies; 4+ messages in thread
From: Miklos Szeredi @ 2022-07-18 14:02 UTC (permalink / raw)
To: Deming Wang
Cc: Vivek Goyal, Stefan Hajnoczi, virtualization, linux-fsdevel,
linux-kernel
On Fri, 10 Jun 2022 at 04:08, Deming Wang <wangdeming@inspur.com> wrote:
>
> fs parameter not used. So, it needs to be deleted.
>
> Signed-off-by: Deming Wang <wangdeming@inspur.com>
Thanks, applied.
Miklos
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-18 14:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-10 2:08 [PATCH] virtiofs: delete unused parameter for virtio_fs_cleanup_vqs Deming Wang
2022-06-15 13:54 ` Stefan Hajnoczi
2022-06-15 17:57 ` Vivek Goyal
2022-07-18 14:02 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).