linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Alessio Balsini <balsini@android.com>
Cc: Arnd Bergmann <arnd@kernel.org>,
	kernel-team <kernel-team@android.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/fuse: Fix matching of FUSE_DEV_IOC_CLONE command
Date: Mon, 22 Mar 2021 16:04:48 +0100	[thread overview]
Message-ID: <CAJfpegsovR6i6tVOzTPP8V8Y9PxmtRx5M+=2Z9oKMcpYO3Dd2Q@mail.gmail.com> (raw)
In-Reply-To: <20210319150514.1315985-1-balsini@android.com>

On Fri, Mar 19, 2021 at 4:06 PM Alessio Balsini <balsini@android.com> wrote:
>
> With commit f8425c939663 ("fuse: 32-bit user space ioctl compat for fuse
> device") the matching constraints for the FUSE_DEV_IOC_CLONE ioctl
> command are relaxed, limited to the testing of command type and number.
> As Arnd noticed, this is wrong as it wouldn't ensure the correctness of
> the data size or direction for the received FUSE device ioctl.
>
> Fix by bringing back the comparison of the ioctl received by the FUSE
> device to the originally generated FUSE_DEV_IOC_CLONE.
>
> Fixes: f8425c939663 ("fuse: 32-bit user space ioctl compat for fuse device")
> Reported-by: Arnd Bergmann <arnd@kernel.org>
> Signed-off-by: Alessio Balsini <balsini@android.com>

Thanks, applied.   I'm holding this till the 5.13 merge window unless
a more series fuse issue emerges in the meantime

Thanks,
Miklos

      reply	other threads:[~2021-03-22 15:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 15:05 [PATCH] fs/fuse: Fix matching of FUSE_DEV_IOC_CLONE command Alessio Balsini
2021-03-22 15:04 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegsovR6i6tVOzTPP8V8Y9PxmtRx5M+=2Z9oKMcpYO3Dd2Q@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=arnd@kernel.org \
    --cc=balsini@android.com \
    --cc=kernel-team@android.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).