From: Miklos Szeredi <miklos@szeredi.hu>
To: "Caldwell, Blake A." <blakec@ornl.gov>
Cc: Eric Jones <ejones@cray.com>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>,
Linux-Fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Support for filesystems with d_revalidate (NFS)
Date: Tue, 10 Feb 2015 21:28:10 +0100 [thread overview]
Message-ID: <CAJfpegssRaFSZXJbKcJGqef-_X3P24LSJF+ODP2sE_QZQa5=hQ@mail.gmail.com> (raw)
In-Reply-To: <C111BFAB-F3C3-49AA-A34E-3E110EC86229@ornl.gov>
On Tue, Feb 10, 2015 at 7:26 PM, Caldwell, Blake A. <blakec@ornl.gov> wrote:
> Thanks. That could help in the short-term. I'd hope to see see this in mainline eventually. If someone could elaborate on the blanket exclusion of d_revalidate, I'd like to see if the task to add read-only NFS support is reasonable.
It was easier to merge upstream that way (the acutal change was
suggested by Al Viro). We could add it back if we can show that it
doesn't hurt.
Generally distributed fs need ->d_revalidate because filesystem can
change without any write activity on the local mount (and even if
mounted read-only) to check for remote changes.
Overlayfs assumes that lower fs is constant and behavior is undefined
if the underlying filesystem changes. So basically we don't care
about d_revalidate, but may still want to call it due to possible
assumptions about it being called by the VFS.
So easy option is to call ->d_revalidate and error out if it returns "invalid"
Thanks,
Miklos
parent reply other threads:[~2015-02-10 20:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <C111BFAB-F3C3-49AA-A34E-3E110EC86229@ornl.gov>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegssRaFSZXJbKcJGqef-_X3P24LSJF+ODP2sE_QZQa5=hQ@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=blakec@ornl.gov \
--cc=ejones@cray.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).