* Re: Support for filesystems with d_revalidate (NFS)
[not found] ` <C111BFAB-F3C3-49AA-A34E-3E110EC86229@ornl.gov>
@ 2015-02-10 20:28 ` Miklos Szeredi
0 siblings, 0 replies; only message in thread
From: Miklos Szeredi @ 2015-02-10 20:28 UTC (permalink / raw)
To: Caldwell, Blake A.
Cc: Eric Jones, linux-unionfs@vger.kernel.org, Linux-Fsdevel
On Tue, Feb 10, 2015 at 7:26 PM, Caldwell, Blake A. <blakec@ornl.gov> wrote:
> Thanks. That could help in the short-term. I'd hope to see see this in mainline eventually. If someone could elaborate on the blanket exclusion of d_revalidate, I'd like to see if the task to add read-only NFS support is reasonable.
It was easier to merge upstream that way (the acutal change was
suggested by Al Viro). We could add it back if we can show that it
doesn't hurt.
Generally distributed fs need ->d_revalidate because filesystem can
change without any write activity on the local mount (and even if
mounted read-only) to check for remote changes.
Overlayfs assumes that lower fs is constant and behavior is undefined
if the underlying filesystem changes. So basically we don't care
about d_revalidate, but may still want to call it due to possible
assumptions about it being called by the VFS.
So easy option is to call ->d_revalidate and error out if it returns "invalid"
Thanks,
Miklos
^ permalink raw reply [flat|nested] only message in thread