* [PATCH] fuse: removed unused function fuse_uring_create() from header
@ 2025-02-07 13:35 Luis Henriques
2025-02-07 13:42 ` Bernd Schubert
2025-02-14 9:48 ` Miklos Szeredi
0 siblings, 2 replies; 3+ messages in thread
From: Luis Henriques @ 2025-02-07 13:35 UTC (permalink / raw)
To: Miklos Szeredi, Bernd Schubert
Cc: linux-fsdevel, linux-kernel, Luis Henriques
Function fuse_uring_create() is used only from dev_uring.c and does not
need to be exposed in the header file. Furthermore, it has the wrong
signature.
While there, also remove the 'struct fuse_ring' forward declaration.
Signed-off-by: Luis Henriques <luis@igalia.com>
---
fs/fuse/dev_uring_i.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/fs/fuse/dev_uring_i.h b/fs/fuse/dev_uring_i.h
index 2102b3d0c1ae..0d67738850c5 100644
--- a/fs/fuse/dev_uring_i.h
+++ b/fs/fuse/dev_uring_i.h
@@ -172,12 +172,6 @@ static inline bool fuse_uring_ready(struct fuse_conn *fc)
#else /* CONFIG_FUSE_IO_URING */
-struct fuse_ring;
-
-static inline void fuse_uring_create(struct fuse_conn *fc)
-{
-}
-
static inline void fuse_uring_destruct(struct fuse_conn *fc)
{
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fuse: removed unused function fuse_uring_create() from header
2025-02-07 13:35 [PATCH] fuse: removed unused function fuse_uring_create() from header Luis Henriques
@ 2025-02-07 13:42 ` Bernd Schubert
2025-02-14 9:48 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Bernd Schubert @ 2025-02-07 13:42 UTC (permalink / raw)
To: Luis Henriques, Miklos Szeredi; +Cc: linux-fsdevel, linux-kernel
On 2/7/25 14:35, Luis Henriques wrote:
> Function fuse_uring_create() is used only from dev_uring.c and does not
> need to be exposed in the header file. Furthermore, it has the wrong
> signature.
>
> While there, also remove the 'struct fuse_ring' forward declaration.
>
> Signed-off-by: Luis Henriques <luis@igalia.com>
> ---
> fs/fuse/dev_uring_i.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/fuse/dev_uring_i.h b/fs/fuse/dev_uring_i.h
> index 2102b3d0c1ae..0d67738850c5 100644
> --- a/fs/fuse/dev_uring_i.h
> +++ b/fs/fuse/dev_uring_i.h
> @@ -172,12 +172,6 @@ static inline bool fuse_uring_ready(struct fuse_conn *fc)
>
> #else /* CONFIG_FUSE_IO_URING */
>
> -struct fuse_ring;
> -
> -static inline void fuse_uring_create(struct fuse_conn *fc)
> -{
> -}
> -
> static inline void fuse_uring_destruct(struct fuse_conn *fc)
> {
> }
Ah yes, that is left over from earlier patch sets that were
still using ioctls.
Reviewed-by: Bernd Schubert <bschubert@ddn.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fuse: removed unused function fuse_uring_create() from header
2025-02-07 13:35 [PATCH] fuse: removed unused function fuse_uring_create() from header Luis Henriques
2025-02-07 13:42 ` Bernd Schubert
@ 2025-02-14 9:48 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Miklos Szeredi @ 2025-02-14 9:48 UTC (permalink / raw)
To: Luis Henriques; +Cc: Bernd Schubert, linux-fsdevel, linux-kernel
On Fri, 7 Feb 2025 at 14:35, Luis Henriques <luis@igalia.com> wrote:
>
> Function fuse_uring_create() is used only from dev_uring.c and does not
> need to be exposed in the header file. Furthermore, it has the wrong
> signature.
>
> While there, also remove the 'struct fuse_ring' forward declaration.
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-14 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-07 13:35 [PATCH] fuse: removed unused function fuse_uring_create() from header Luis Henriques
2025-02-07 13:42 ` Bernd Schubert
2025-02-14 9:48 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).