From: Miklos Szeredi <miklos@szeredi.hu>
To: Bernd Schubert <bschubert@ddn.com>
Cc: "Vivek Goyal" <vgoyal@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
linux-fsdevel@vger.kernel.org,
"Joanne Koong" <joannelkoong@gmail.com>,
"Josef Bacik" <josef@toxicpanda.com>
Subject: Re: [PATCH RFC 2/4] fuse: Set request unique on allocation
Date: Wed, 2 Apr 2025 20:33:22 +0200 [thread overview]
Message-ID: <CAJfpegt5VGcSPOFA10YhGq6W+pZR8m+YEfhLSL8uFbJhqT7kuA@mail.gmail.com> (raw)
In-Reply-To: <20250402-fuse-io-uring-trace-points-v1-2-11b0211fa658@ddn.com>
On Wed, 2 Apr 2025 at 19:41, Bernd Schubert <bschubert@ddn.com> wrote:
>
> This is especially needed for better ftrace analysis,
> for example to build histograms. So far the request unique
> was missing, because it was added after the first trace message.
>
> IDs/req-unique now might not come up perfectly sequentially
> anymore, but especially with cloned device or io-uring this
> did not work perfectly anyway.
Well, we can try in any case. It would be a pretty insane server that
actually looks at the h->unique value, but not impossible.
Thanks,
Miklos
next prev parent reply other threads:[~2025-04-02 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 17:40 [PATCH 0/4] fuse: Improve ftraces, atomic req unique and code dup removal Bernd Schubert
2025-04-02 17:40 ` [PATCH 1/4] fuse: Make the fuse_send_one request counter atomic Bernd Schubert
2025-04-02 18:29 ` Miklos Szeredi
2025-04-03 9:16 ` Bernd Schubert
2025-04-03 12:15 ` Miklos Szeredi
2025-04-03 13:06 ` Bernd Schubert
2025-04-02 17:40 ` [PATCH RFC 2/4] fuse: Set request unique on allocation Bernd Schubert
2025-04-02 18:33 ` Miklos Szeredi [this message]
2025-04-03 13:08 ` Bernd Schubert
2025-04-02 17:40 ` [PATCH 3/4] fuse: {io-uring} Avoid _send code dup Bernd Schubert
2025-04-02 17:40 ` [PATCH 4/4] fuse: fine-grained request ftraces Bernd Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegt5VGcSPOFA10YhGq6W+pZR8m+YEfhLSL8uFbJhqT7kuA@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=bschubert@ddn.com \
--cc=eperezma@redhat.com \
--cc=joannelkoong@gmail.com \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).