From: Miklos Szeredi <miklos@szeredi.hu>
To: Dharmendra Singh <dharamhans87@gmail.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
linux-fsdevel@vger.kernel.org,
fuse-devel <fuse-devel@lists.sourceforge.net>,
linux-kernel@vger.kernel.org, Bernd Schubert <bschubert@ddn.com>,
Dharmendra Singh <dsingh@ddn.com>
Subject: Re: [PATCH v5 1/1] Allow non-extending parallel direct writes on the same file.
Date: Fri, 17 Jun 2022 09:36:10 +0200 [thread overview]
Message-ID: <CAJfpegtRzDbcayn7MYKpgO1MBFeBihyfRB402JHtJkbXg1dvLg@mail.gmail.com> (raw)
In-Reply-To: <20220617071027.6569-2-dharamhans87@gmail.com>
On Fri, 17 Jun 2022 at 09:10, Dharmendra Singh <dharamhans87@gmail.com> wrote:
> This patch relaxes the exclusive lock for direct non-extending writes
> only. File size extending writes might not need the lock either,
> but we are not entirely sure if there is a risk to introduce any
> kind of regression. Furthermore, benchmarking with fio does not
> show a difference between patch versions that take on file size
> extension a) an exclusive lock and b) a shared lock.
I'm okay with this, but ISTR Bernd noted a real-life scenario where
this is not sufficient. Maybe that should be mentioned in the patch
header?
Thanks,
Miklos
next prev parent reply other threads:[~2022-06-17 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 7:10 [PATCH v5 0/1] FUSE: Allow non-extending parallel direct writes Dharmendra Singh
2022-06-17 7:10 ` [PATCH v5 1/1] Allow non-extending parallel direct writes on the same file Dharmendra Singh
2022-06-17 7:36 ` Miklos Szeredi [this message]
2022-06-17 9:25 ` Bernd Schubert
2022-06-17 12:43 ` Miklos Szeredi
2022-06-17 13:07 ` Bernd Schubert
2022-09-13 8:44 ` Bernd Schubert
2022-10-20 14:51 ` Bernd Schubert
2022-10-21 6:57 ` Miklos Szeredi
2022-10-21 9:16 ` Bernd Schubert
2022-06-18 19:07 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegtRzDbcayn7MYKpgO1MBFeBihyfRB402JHtJkbXg1dvLg@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=bschubert@ddn.com \
--cc=dharamhans87@gmail.com \
--cc=dsingh@ddn.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).