From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B2BBC432C0 for ; Mon, 25 Nov 2019 15:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CEAF520740 for ; Mon, 25 Nov 2019 15:14:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=szeredi.hu header.i=@szeredi.hu header.b="Uhh7wOIq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728390AbfKYPON (ORCPT ); Mon, 25 Nov 2019 10:14:13 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:34775 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728368AbfKYPON (ORCPT ); Mon, 25 Nov 2019 10:14:13 -0500 Received: by mail-io1-f67.google.com with SMTP id z193so16642834iof.1 for ; Mon, 25 Nov 2019 07:14:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ALu9igSRSsKi52hn+f9OyAjdyB0mBhNXe9BnXNqIOe4=; b=Uhh7wOIqPQR81MSbRooLEt8qyy+07qluJoDtNGDtuedJKTsKjd14fVckV+hyDQmbo6 78MPzzDXsUkzjxgRhAEm9siOrRhNZUiy8r2DTW7OWcdnHo7YHAbfbIO7lH/4mUPXSThw yCn+Oo5iRpC87zL2LqOdI1JCfz+ssecH+ma6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ALu9igSRSsKi52hn+f9OyAjdyB0mBhNXe9BnXNqIOe4=; b=jrmPtvaHXaYdDKBcfoHZ+vHdlN0jyHMy36vuvd6cRhc44c6tU9crHk90jw7K+PAl// BUTl3rEB3xRiP/Y5/7GPyTjrWP2PTc+e/iU6uuns6WGMpF9g4Zegu2NQAlwe9aAO0oT9 ZbUuAGluub70ME67BTn9XC433QZ5zBFFoMYJaiSdAupD1Bw77zEbxXg6V5DrP2q4JjC9 c/qG+7JfrRQiF57pb6sQ11nKC5MlMZ/lp/FzQRKmlYGyggz2qC4eUtQEUlltgXRkfIFa eMBepcZJFuV7yidrT5vF2WOpRCx7VAuQdQlpdHW9yXOW9umF1jlmFKuwxyNOEUuk9qme Yh6A== X-Gm-Message-State: APjAAAXm/Sjg8/imR04mtOhLvVqrtbAEGdL8ujOyBSgk92Rg0deIkDiI ubcUYrFAKMtdoL/eheGJ5VH/h6EtqnWNRmcMMItN5g== X-Google-Smtp-Source: APXvYqymUw8TAznCvAM14YFrTvY36Km1p/Eylp7nwOHjzN72m1nqZQk+qCIweSmRGc14oNLOCMmjpk2sZSwXjZnmUyo= X-Received: by 2002:a5d:91da:: with SMTP id k26mr26131450ior.252.1574694852323; Mon, 25 Nov 2019 07:14:12 -0800 (PST) MIME-Version: 1.0 References: <20191025112917.22518-1-mszeredi@redhat.com> <87r231rlfj.fsf@x220.int.ebiederm.org> In-Reply-To: <87r231rlfj.fsf@x220.int.ebiederm.org> From: Miklos Szeredi Date: Mon, 25 Nov 2019 16:14:01 +0100 Message-ID: Subject: Re: [RFC PATCH 0/5] allow unprivileged overlay mounts To: "Eric W. Biederman" Cc: Miklos Szeredi , overlayfs , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Oct 25, 2019 at 3:43 PM Eric W. Biederman wrote: > > Miklos Szeredi writes: > > > Hi Eric, > > > > Can you please have a look at this patchset? > > > > The most interesting one is the last oneliner adding FS_USERNS_MOUNT; > > whether I'm correct in stating that this isn't going to introduce any > > holes, or not... > > I will take some time and dig through this. > > From a robustness standpoint I worry about the stackable filesystem > side. As that is uniquely an attack vector with overlayfs. > > There is definitely demand for this. Hi Eric, Have you had time to look into this yet? Thanks, Miklos