From: Miklos Szeredi <miklos@szeredi.hu>
To: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>,
me@jcix.top
Subject: Re: [PATCH 2/2] fuse: remove an unnecessary if statement
Date: Wed, 6 Mar 2024 10:13:29 +0100 [thread overview]
Message-ID: <CAJfpegtnTafRiHGG6jpZaZ_XbOhT2aGFyZM3FeDdPoSSEanNNw@mail.gmail.com> (raw)
In-Reply-To: <20230608084609.14245-3-zhangjiachen.jaycee@bytedance.com>
On Thu, 8 Jun 2023 at 10:47, Jiachen Zhang
<zhangjiachen.jaycee@bytedance.com> wrote:
>
> FUSE remote locking code paths never add any locking state to
> inode->i_flctx, so the locks_remove_posix() function called on
> file close will return without calling fuse_setlk().
>
> Therefore, as the if statement to be removed in this commit will
> always be false, remove it for clearness.
>
> Fixes: 7142125937e1 ("[PATCH] fuse: add POSIX file locking support")
> Signed-off-by: Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>
Applied, thanks.
Miklos
prev parent reply other threads:[~2024-03-06 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 8:46 [PATCH 0/2] fuse: fixes for remote locking Jiachen Zhang
2023-06-08 8:46 ` [PATCH 1/2] fuse: support unlock remote OFD locks on file release Jiachen Zhang
2023-06-18 15:04 ` Jochen Friedrich
2023-06-08 8:46 ` [PATCH 2/2] fuse: remove an unnecessary if statement Jiachen Zhang
2024-03-06 9:13 ` Miklos Szeredi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegtnTafRiHGG6jpZaZ_XbOhT2aGFyZM3FeDdPoSSEanNNw@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@jcix.top \
--cc=zhangjiachen.jaycee@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).