From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCD24C433F5 for ; Fri, 30 Sep 2022 13:01:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbiI3NBj (ORCPT ); Fri, 30 Sep 2022 09:01:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229741AbiI3NBh (ORCPT ); Fri, 30 Sep 2022 09:01:37 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29DF110EEE0 for ; Fri, 30 Sep 2022 06:01:35 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id lc7so8937464ejb.0 for ; Fri, 30 Sep 2022 06:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Rp0BnqbKwjG9lV6J/Ph85TR4tMAevzJG6WiMgOhpmug=; b=pT0ssIu03xvv3jvV0fx6jXVbVLxoiVjnxkCqGNCCqBKh7QlPzjyzY/PXMCu5jyX4Ma 2RPiuodk64PGsecSuvkaGIHvzuJJMMXRfgbJSe4Ho8K8HMdgD9kQuqZI7+5maAveCauC cvhoJC9BNQHkDurnQm+Yvhn/6hzB6MvWFAXcQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Rp0BnqbKwjG9lV6J/Ph85TR4tMAevzJG6WiMgOhpmug=; b=SJIZgAHaC5G5T5TQX9OsPzCDliXH6oRFrKMmf+RQDZQl9x3cous5Pf3hWha3CyVvTm 7l/HJLk9ykIJoXqF09SJsGzX1q795GRayHn7oKS9bn4ISdRkWe3XFVI6z9jRPdOIIqF8 fTR8IwECnbi+jR1BcrDyTJdq/xx4HOh96Ja2wlTDR3TZDI8IspT01zZ2Lc/ueExONp83 jtn9QDVnK/6AL7JXDhO4rk3Egh1YrlgnJEgou5t1dIRCnYF2iRtXU8seJut4KYcHa6B0 mZQGcWreNTnO239WZ0OXkMDHH1daks8isC0lVLGTPASzE7NWgMPou3h1Gut1HLiukYN2 VUmw== X-Gm-Message-State: ACrzQf1SAmrWHylUVqT64PthyjZwcyo1bUcr7A10N4X214enUO8VTQYt xUwDmGiLRU7bqqYUMAxcjXreiIhTauv9aFW/XpHpcA== X-Google-Smtp-Source: AMsMyM62iCWPdnNsF6dG3Wf9BL4+iOR0yxbvKa+bY7kj2X4bZFqDIRC02kpTT/KqFsUGCjAWD3wXHAtTMzMUEz9uzK4= X-Received: by 2002:a17:907:62a1:b0:781:b320:90c0 with SMTP id nd33-20020a17090762a100b00781b32090c0mr6094773ejc.255.1664542893721; Fri, 30 Sep 2022 06:01:33 -0700 (PDT) MIME-Version: 1.0 References: <20220929153041.500115-1-brauner@kernel.org> <20220929153041.500115-5-brauner@kernel.org> <20220930090949.cl3ajz7r4ub6jrae@wittgenstein> <20220930100557.7hqjrz77s3wcbrxx@wittgenstein> <20220930124948.2mhh4bsojrlqbsmu@wittgenstein> In-Reply-To: <20220930124948.2mhh4bsojrlqbsmu@wittgenstein> From: Miklos Szeredi Date: Fri, 30 Sep 2022 15:01:22 +0200 Message-ID: Subject: Re: [PATCH v4 04/30] fs: add new get acl method To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Seth Forshee , Christoph Hellwig , Al Viro , linux-security-module@vger.kernel.org, Steve French Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, 30 Sept 2022 at 14:49, Christian Brauner wrote: > > On Fri, Sep 30, 2022 at 02:24:33PM +0200, Miklos Szeredi wrote: > > Maybe adding the check to ovl_get_acl() is the right way to go, but > > I'm a little afraid of a performance regression. Will look into that. > > Ok, sounds good. I can probably consolidate the two versions but retain > the difference in permission checking or would you prefer I leave them > distinct for now? No, please consolidate them. That's a good first step. > > So this patchset nicely reveals how acl retrieval could be done two > > ways, and how overlayfs employed both for different purposes. But > > what would be even nicer if there was just one way to retrieve the acl > > and overlayfs and cifs be moved over to that. > > I think this is a good long term goal to have. We're certainly not done > with improving things after this work. Sometimes it just takes a little > time to phase out legacy baggage as we all are well aware. But then which is legacy? The old .get_acl() or the new .get_acl()? My impression is that it's the new one. But in that case the big renaming patch doesn't make any sense. Thanks, Miklos