From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 391BEC77B7A for ; Sun, 11 Jun 2023 19:37:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233330AbjFKThQ (ORCPT ); Sun, 11 Jun 2023 15:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbjFKThP (ORCPT ); Sun, 11 Jun 2023 15:37:15 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84418E3 for ; Sun, 11 Jun 2023 12:37:14 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-977cc662f62so526555066b.3 for ; Sun, 11 Jun 2023 12:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1686512233; x=1689104233; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t53JaZQiA5kvc2UsfPRnIjKanstp7CpQK0e3h3rebXw=; b=pO+zErFXvUdqeIlRDqBXFoYkofdje3Ddh+WYCdNVBNhSfYqYyIaIEjxsVQvD4Q+jct 9n/9LXYjyJMRtDfKw4FcU0oAKZrfNTQqoTMRKVHWUHuSfrSodD00LoAX+/c3ZcCh3ToV 0G7NG1lvuMUyaIkD8+dswATodhjq9W4isytg4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686512233; x=1689104233; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t53JaZQiA5kvc2UsfPRnIjKanstp7CpQK0e3h3rebXw=; b=ODope4sZtxMwfxFnjgbDm3dlBq6B3H/+nAewbTJoAjoOqTNS5uBKWc5jr1Ar5ntWSF 4sjijgMcVQZRN15Sicwm2+7b1R5JkKK/TjiER8/RWtcXZCXrem6Oq5F2QjIkgauizB3F GLTIa2BVPNL2ZOBGsL9Dmh0qNTHrcC321jYGYbOuXA/D4hBg7LohEvjd82eRc5PWA1dg ROxNpDvYcY0tIsl+YN9bDZvzdi5NgpfsFI1FXslcn3Q+KNso5ACkxaYy756TAQQZ/FVC qqG3b0OgF7xTR95h9rPT1+18e3wkHWZdIQnFvIRkvyoCo5OagD0zknqD671EpWiE9Vnv 5HUA== X-Gm-Message-State: AC+VfDzS+OrtDuzsb6XC8aQcyv+JvOj+mB6YAF50wRSRp7PLMd+xyvSF FcVgHU5QKHjSyNqlIC697/UJDN3vGUi8ZT6dVmBFWw== X-Google-Smtp-Source: ACHHUZ5gn4mgbBGusibGRfBYjdC4JSEfnJRLz2fn+8jyQQmfpVTtcfUYyIR2mGwB10EyfM/GUHE2hlZR+Vpjv8acxWU= X-Received: by 2002:a17:907:3181:b0:974:326b:3362 with SMTP id xe1-20020a170907318100b00974326b3362mr6917556ejb.44.1686512232809; Sun, 11 Jun 2023 12:37:12 -0700 (PDT) MIME-Version: 1.0 References: <20230611132732.1502040-1-amir73il@gmail.com> In-Reply-To: From: Miklos Szeredi Date: Sun, 11 Jun 2023 21:37:01 +0200 Message-ID: Subject: Re: [PATCH v2 0/3] Handle notifications on overlayfs fake path files To: Amir Goldstein Cc: Christian Brauner , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sun, 11 Jun 2023 at 21:25, Amir Goldstein wrote: > > On Sun, Jun 11, 2023 at 10:12=E2=80=AFPM Miklos Szeredi wrote: > > > > On Sun, 11 Jun 2023 at 19:52, Amir Goldstein wrote= : > > > > > Is it because getting f_real_path() and file_dentry() via d_real() > > > is more expensive? > > > and caching this information in file_fake container would be > > > more efficient? > > > > > > I will restore the file_fake container and post v3. > > > > I simply dislike the fact that ->d_real() is getting more complex. > > I'd prefer d_real to die, which is unfortunately not so easy, as > > you've explained. > > > > But if we can make it somewhat less complex (remove the inode > > parameter) instead of more complex (add a vfsmount * parameter) then > > that's already a big win in my eyes. > > > > OK, I can relate to that. > > Here is file_fake restored, now with fsnotify fix also tested: > > https://github.com/amir73il/linux/commits/ovl_fake_path > > IIUC, you would now want to change file_dentry(f) to using > f_real_file(f)->dentry and get rid of the inode argument to d_real(). > > Do you want that change also in v3 or should we save some fun for later > and just fix fsnotify for now? Can do that later. Small steps are good. Thanks, Miklos