* [PATCH] fuse: remove unused 'inode' parameter in fuse_passthrough_open
@ 2025-07-30 13:06 Chunsheng Luo
2025-07-31 20:54 ` Joanne Koong
2025-08-19 10:54 ` Miklos Szeredi
0 siblings, 2 replies; 3+ messages in thread
From: Chunsheng Luo @ 2025-07-30 13:06 UTC (permalink / raw)
To: miklos; +Cc: mszeredi, amir73il, linux-fsdevel, linux-kernel, Chunsheng Luo
The 'inode' parameter in fuse_passthrough_open() is never referenced
in the function implementation.
Signed-off-by: Chunsheng Luo <luochunsheng@ustc.edu>
---
fs/fuse/fuse_i.h | 4 +---
fs/fuse/iomode.c | 3 +--
fs/fuse/passthrough.c | 4 +---
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
index ec248d13c8bf..92c2932daea1 100644
--- a/fs/fuse/fuse_i.h
+++ b/fs/fuse/fuse_i.h
@@ -1538,9 +1538,7 @@ void fuse_backing_files_free(struct fuse_conn *fc);
int fuse_backing_open(struct fuse_conn *fc, struct fuse_backing_map *map);
int fuse_backing_close(struct fuse_conn *fc, int backing_id);
-struct fuse_backing *fuse_passthrough_open(struct file *file,
- struct inode *inode,
- int backing_id);
+struct fuse_backing *fuse_passthrough_open(struct file *file, int backing_id);
void fuse_passthrough_release(struct fuse_file *ff, struct fuse_backing *fb);
static inline struct file *fuse_file_passthrough(struct fuse_file *ff)
diff --git a/fs/fuse/iomode.c b/fs/fuse/iomode.c
index c99e285f3183..3728933188f3 100644
--- a/fs/fuse/iomode.c
+++ b/fs/fuse/iomode.c
@@ -177,8 +177,7 @@ static int fuse_file_passthrough_open(struct inode *inode, struct file *file)
(ff->open_flags & ~FOPEN_PASSTHROUGH_MASK))
return -EINVAL;
- fb = fuse_passthrough_open(file, inode,
- ff->args->open_outarg.backing_id);
+ fb = fuse_passthrough_open(file, ff->args->open_outarg.backing_id);
if (IS_ERR(fb))
return PTR_ERR(fb);
diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c
index 607ef735ad4a..0c8e36db41ba 100644
--- a/fs/fuse/passthrough.c
+++ b/fs/fuse/passthrough.c
@@ -301,9 +301,7 @@ int fuse_backing_close(struct fuse_conn *fc, int backing_id)
*
* Returns an fb object with elevated refcount to be stored in fuse inode.
*/
-struct fuse_backing *fuse_passthrough_open(struct file *file,
- struct inode *inode,
- int backing_id)
+struct fuse_backing *fuse_passthrough_open(struct file *file, int backing_id)
{
struct fuse_file *ff = file->private_data;
struct fuse_conn *fc = ff->fm->fc;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fuse: remove unused 'inode' parameter in fuse_passthrough_open
2025-07-30 13:06 [PATCH] fuse: remove unused 'inode' parameter in fuse_passthrough_open Chunsheng Luo
@ 2025-07-31 20:54 ` Joanne Koong
2025-08-19 10:54 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Joanne Koong @ 2025-07-31 20:54 UTC (permalink / raw)
To: Chunsheng Luo; +Cc: miklos, mszeredi, amir73il, linux-fsdevel, linux-kernel
On Wed, Jul 30, 2025 at 6:06 AM Chunsheng Luo <luochunsheng@ustc.edu> wrote:
>
> The 'inode' parameter in fuse_passthrough_open() is never referenced
> in the function implementation.
>
> Signed-off-by: Chunsheng Luo <luochunsheng@ustc.edu>
LGTM
Reviewed-by: Joanne Koong <joannelkoong@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fuse: remove unused 'inode' parameter in fuse_passthrough_open
2025-07-30 13:06 [PATCH] fuse: remove unused 'inode' parameter in fuse_passthrough_open Chunsheng Luo
2025-07-31 20:54 ` Joanne Koong
@ 2025-08-19 10:54 ` Miklos Szeredi
1 sibling, 0 replies; 3+ messages in thread
From: Miklos Szeredi @ 2025-08-19 10:54 UTC (permalink / raw)
To: Chunsheng Luo; +Cc: mszeredi, amir73il, linux-fsdevel, linux-kernel
On Wed, 30 Jul 2025 at 15:06, Chunsheng Luo <luochunsheng@ustc.edu> wrote:
>
> The 'inode' parameter in fuse_passthrough_open() is never referenced
> in the function implementation.
>
> Signed-off-by: Chunsheng Luo <luochunsheng@ustc.edu>
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-19 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-30 13:06 [PATCH] fuse: remove unused 'inode' parameter in fuse_passthrough_open Chunsheng Luo
2025-07-31 20:54 ` Joanne Koong
2025-08-19 10:54 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).