linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Joanne Koong <joannelkoong@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, josef@toxicpanda.com,
	 bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com,
	laoar.shao@gmail.com,  kernel-team@meta.com
Subject: Re: [PATCH v5 0/2] fuse: add timeout option for requests
Date: Tue, 27 Aug 2024 08:49:35 +0200	[thread overview]
Message-ID: <CAJfpegud2cp6EoGa+Q5og3rEXKf8Ds32wXeReUMMktjDJvtMmQ@mail.gmail.com> (raw)
In-Reply-To: <20240826203234.4079338-1-joannelkoong@gmail.com>

On Mon, 26 Aug 2024 at 22:33, Joanne Koong <joannelkoong@gmail.com> wrote:
>
> There are situations where fuse servers can become unresponsive or
> stuck, for example if the server is in a deadlock. Currently, there's
> no good way to detect if a server is stuck and needs to be killed
> manually.
>
> This patchset adds a timeout option for requests where if the server does not
> reply to the request by the time the timeout elapses, the connection will be
> aborted. This patchset also adds two dynamically configurable fuse sysctls
> "default_request_timeout" and "max_request_timeout" for controlling/enforcing
> timeout behavior system-wide.
>
> Existing fuse servers will not be affected unless they explicitly opt into the
> timeout.

This last paragraph seems to contradict the purpose of the system-wide
maximum timeout.  If the server can opt out of timeouts, then
enforcing a maximum timeout is pointless.

Am I missing something?

Thanks,
Miklos

  parent reply	other threads:[~2024-08-27  6:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 20:32 [PATCH v5 0/2] fuse: add timeout option for requests Joanne Koong
2024-08-26 20:32 ` [PATCH v5 1/2] fuse: add optional kernel-enforced timeout " Joanne Koong
2024-08-26 20:32 ` [PATCH v5 2/2] fuse: add default_request_timeout and max_request_timeout sysctls Joanne Koong
2024-08-27 21:51   ` kernel test robot
2024-08-28 15:51     ` Joanne Koong
2024-08-29  3:58       ` Yafang Shao
2024-08-29  6:38         ` Jingbo Xu
2024-08-29  8:05           ` Yafang Shao
2024-08-27  6:49 ` Miklos Szeredi [this message]
2024-08-27 17:24   ` [PATCH v5 0/2] fuse: add timeout option for requests Joanne Koong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegud2cp6EoGa+Q5og3rEXKf8Ds32wXeReUMMktjDJvtMmQ@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=bernd.schubert@fastmail.fm \
    --cc=jefflexu@linux.alibaba.com \
    --cc=joannelkoong@gmail.com \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@meta.com \
    --cc=laoar.shao@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).