From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com ([74.125.82.41]:45800 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756981AbdKOKfA (ORCPT ); Wed, 15 Nov 2017 05:35:00 -0500 Received: by mail-wm0-f41.google.com with SMTP id 9so1960535wme.4 for ; Wed, 15 Nov 2017 02:35:00 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20171110011419.GP1627@brightrain.aerifal.cx> References: <20161219113800.GE27207@veci.piliscsaba.szeredi.hu> <20171108131005.GA15263@port70.net> <20171110011419.GP1627@brightrain.aerifal.cx> From: Miklos Szeredi Date: Wed, 15 Nov 2017 11:34:58 +0100 Message-ID: Subject: Re: [musl] Re: [(resend)] seq_file: reset iterator to first record for zero offset To: Rich Felker Cc: Szabolcs Nagy , Al Viro , Tomasz Majchrzak , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux API , musl@lists.openwall.com Content-Type: multipart/mixed; boundary="001a1141e49433022b055e030e66" Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --001a1141e49433022b055e030e66 Content-Type: text/plain; charset="UTF-8" On Fri, Nov 10, 2017 at 2:14 AM, Rich Felker wrote: > On Wed, Nov 08, 2017 at 02:10:05PM +0100, Szabolcs Nagy wrote: >> >> this patch broke userspace abi: >> >> commit e522751d605d99a81508e58390a8f51ee96fb662 > > Thanks for reporting this! Thanks for the report and the reproducer. Tested fix attached. Thanks, Miklos --001a1141e49433022b055e030e66 Content-Type: text/x-patch; charset="US-ASCII"; name="seq_file-fix-incomplete-reset-on-read-from-zero-offset.patch" Content-Disposition: attachment; filename="seq_file-fix-incomplete-reset-on-read-from-zero-offset.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ja0wtgqe0 RnJvbTogTWlrbG9zIFN6ZXJlZGkgPG1zemVyZWRpQHJlZGhhdC5jb20+ClN1YmplY3Q6IHNlcV9m aWxlOiBmaXggaW5jb21wbGV0ZSByZXNldCBvbiByZWFkIGZyb20gemVybyBvZmZzZXQKCldoZW4g cmVzZXR0aW5nIGl0ZXJhdG9yIG9uIGEgemVybyBvZmZzZXQgd2UgbmVlZCB0byBkaXNjYXJkIGFu eSBkYXRhCmFscmVhZHkgaW4gdGhlIGJ1ZmZlciAoY291bnQpLCBhbmQgcHJpdmF0ZSBzdGF0ZSBv ZiB0aGUgaXRlcmF0b3IgKHZlcnNpb24pLgoKRm9yIGV4YW1wbGUgdGhpcyBidWcgcmVzdWx0cyBp biBmaXJzdCBsaW5lIGJlaW5nIHJlcGVhdGVkIGluIC9wcm9jL21vdW50cwppZiBkb2luZyBhIHpl cm8gc2l6ZSByZWFkIGJlZm9yZSBhIG5vbi16ZXJvIHNpemUgcmVhZC4KClJlcG9ydGVkLWJ5OiBS aWNoIEZlbGtlciA8ZGFsaWFzQGxpYmMub3JnPiAKU2lnbmVkLW9mZi1ieTogTWlrbG9zIFN6ZXJl ZGkgPG1zemVyZWRpQHJlZGhhdC5jb20+CkZpeGVzOiBlNTIyNzUxZDYwNWQgKCJzZXFfZmlsZTog cmVzZXQgaXRlcmF0b3IgdG8gZmlyc3QgcmVjb3JkIGZvciB6ZXJvIG9mZnNldCIpCkNjOiA8c3Rh YmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMAotLS0KIGZzL3NlcV9maWxlLmMgfCAgICA1ICsr KystCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgotLS0g YS9mcy9zZXFfZmlsZS5jCisrKyBiL2ZzL3NlcV9maWxlLmMKQEAgLTE4MSw4ICsxODEsMTEgQEAg c3NpemVfdCBzZXFfcmVhZChzdHJ1Y3QgZmlsZSAqZmlsZSwgY2hhcgogCSAqIGlmIHJlcXVlc3Qg aXMgdG8gcmVhZCBmcm9tIHplcm8gb2Zmc2V0LCByZXNldCBpdGVyYXRvciB0byBmaXJzdAogCSAq IHJlY29yZCBhcyBpdCBtaWdodCBoYXZlIGJlZW4gYWxyZWFkeSBhZHZhbmNlZCBieSBwcmV2aW91 cyByZXF1ZXN0cwogCSAqLwotCWlmICgqcHBvcyA9PSAwKQorCWlmICgqcHBvcyA9PSAwKSB7CiAJ CW0tPmluZGV4ID0gMDsKKwkJbS0+dmVyc2lvbiA9IDA7CisJCW0tPmNvdW50ID0gMDsKKwl9CiAK IAkvKiBEb24ndCBhc3N1bWUgKnBwb3MgaXMgd2hlcmUgd2UgbGVmdCBpdCAqLwogCWlmICh1bmxp a2VseSgqcHBvcyAhPSBtLT5yZWFkX3BvcykpIHsK --001a1141e49433022b055e030e66--