From: Miklos Szeredi <miklos@szeredi.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: [GIT PULL] overlayfs fix for 4.8-rc5
Date: Fri, 9 Sep 2016 22:08:20 +0200 [thread overview]
Message-ID: <CAJfpegvMZrF70LgR4hU84GxvvGQ1JcTFMoG1yH78Rh+v2cFuqw@mail.gmail.com> (raw)
In-Reply-To: <CA+55aFxX-UbDjL8R1beqP_ZE6-eXJMgnuvPZmJQxA9n-3srEQQ@mail.gmail.com>
On Fri, Sep 9, 2016 at 9:58 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Sep 9, 2016 at 12:37 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
>>
>> This fixes a regression caused by the last pull request.
>
> So why are you checking error numbers one by one?
>
> Why is an error not just always an error?
The issue is that not all errors should result in failure.
That code tries to remove ACL from a directory, and there are several cases:
1) success: that's good obviously
2) error: no ACL was found: that's also good
3) error: ACL's are not supported by the filesystem: this is also good
4) error: ACL was there but we failed to remove it for some other
reason: this is not good
The patch adds handling of case 3.
Thanks,
Miklos
next prev parent reply other threads:[~2016-09-09 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 19:37 [GIT PULL] overlayfs fix for 4.8-rc5 Miklos Szeredi
2016-09-09 19:58 ` Linus Torvalds
2016-09-09 20:08 ` Miklos Szeredi [this message]
2016-09-09 20:36 ` Linus Torvalds
2016-09-09 21:18 ` Miklos Szeredi
2016-09-09 21:47 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegvMZrF70LgR4hU84GxvvGQ1JcTFMoG1yH78Rh+v2cFuqw@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).