From: Miklos Szeredi <miklos@szeredi.hu>
To: Kirill Smelkov <kirr@nexedi.com>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
linux-fsdevel@vger.kernel.org,
fuse-devel <fuse-devel@lists.sourceforge.net>,
Han-Wen Nienhuys <hanwen@google.com>,
Jakob Unterwurzacher <jakobunt@gmail.com>,
stable <stable@vger.kernel.org>
Subject: Re: [RESEND, PATCH v2] fuse: Don't drop NOTIFY_REPLY if we promised it
Date: Thu, 28 Feb 2019 09:10:15 +0100 [thread overview]
Message-ID: <CAJfpegvXK+AmpWFSF1qdVt+EFTBwU94AD_JZCEeFF1KEZCObwA@mail.gmail.com> (raw)
In-Reply-To: <20190227203903.GA2798@deco.navytux.spb.ru>
On Wed, Feb 27, 2019 at 9:39 PM Kirill Smelkov <kirr@nexedi.com> wrote:
> I more or less agree with this statement. However can we please make the
> breakage to be explicitly visible with an error instead of exhibiting it
> via harder to debug stucks/deadlocks? For example sys_read < max_write
> -> error instead of getting stuck. And if notify_retrieve requests
> buffer larger than max_write -> error or cut to max_write, but don't
> return OK when we know we will never send what was requested to
> filesystem even if it uses max_write sized reads. What is the point of
> breaking in hard to diagnose way when we can make the breakage showing
> itself explicitly? Would a patch for such behaviour accepted?
Sure, if it's only adds a couple of lines. Adding more than say ten
lines for such a non-bug fix is definitely excessive.
Thanks,
Miklos
next prev parent reply other threads:[~2019-02-28 8:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 9:42 [RESEND, PATCH v2] fuse: Don't drop NOTIFY_REPLY if we promised it Kirill Smelkov
2019-02-26 15:14 ` Miklos Szeredi
2019-02-27 20:02 ` Kirill Smelkov
2019-02-27 20:26 ` Miklos Szeredi
2019-02-27 20:39 ` Kirill Smelkov
2019-02-28 8:10 ` Miklos Szeredi [this message]
2019-02-28 11:48 ` Kirill Smelkov
2019-02-28 11:50 ` [PATCH 2/2] fuse: require /dev/fuse reads to have enough buffer capacity as negotiated Kirill Smelkov
2019-03-07 9:34 ` [RESEND, PATCH v2] fuse: Don't drop NOTIFY_REPLY if we promised it Kirill Smelkov
2019-03-14 10:45 ` [RESEND3, PATCH 0/2] fuse: don't stuck clients on retrieve_notify with size > max_write Kirill Smelkov
2019-03-14 10:46 ` [PATCH 1/2] fuse: retrieve: cap requested size to negotiated max_write Kirill Smelkov
2019-03-14 10:46 ` [PATCH 2/2] fuse: require /dev/fuse reads to have enough buffer capacity as negotiated Kirill Smelkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegvXK+AmpWFSF1qdVt+EFTBwU94AD_JZCEeFF1KEZCObwA@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=fuse-devel@lists.sourceforge.net \
--cc=hanwen@google.com \
--cc=jakobunt@gmail.com \
--cc=kirr@nexedi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).