From: Miklos Szeredi <miklos@szeredi.hu>
To: Srinivas Eeda <srinivas.eeda@oracle.com>
Cc: Linux-Fsdevel <linux-fsdevel@vger.kernel.org>,
fuse-devel <fuse-devel@lists.sourceforge.net>,
Stefan Westerfeld <stefan@space.twc.de>,
Anand Avati <anand.avati@gmail.com>,
Nikolaus Rath <Nikolaus@rath.org>,
hanwenn@gmail.com
Subject: Re: [fuse-devel] FUSE: fixes to improve scalability on NUMA systems
Date: Wed, 1 May 2013 11:53:14 +0200 [thread overview]
Message-ID: <CAJfpegvi=Npv1Da2gqDb50xWzO4GHusbrwZMn5tUp8hQ89AJjQ@mail.gmail.com> (raw)
In-Reply-To: <51800D68.9010700@oracle.com>
[CC-s added]
On Tue, Apr 30, 2013 at 8:28 PM, Srinivas Eeda <srinivas.eeda@oracle.com> wrote:
> The reason I targeted NUMA is because NUMA machine is where I am seeing
> significant performance issues. Even on a NUMA system if I bind all user
> threads to a particular NUMA node, there is no notable performance issue.
> The test I ran was to start multiple(from 4 to 128) "dd if=/dev/zero
> of=/dbfsfilesxx bs=1M count=4000" on a system which has 8 NUMA nodes where
> each node has 20 cores. So total cpu's were 160.
>>
>> http://thread.gmane.org/gmane.comp.file-systems.fuse.devel/11832/
>>
>
> That was a good discussion. The problem discussed here is much more fine
> grained than mine. Fix I emailed, proposes to bind requests to within a NUMA
> node vs the above discussion that proposes to bind requests to within cpu.
> Based on your agreement with Anand Avati I think you prefer to bind requests
> to cpu.
Yes, that's one direction worth exploring.
> http://article.gmane.org/gmane.comp.file-systems.fuse.devel/11909
>
> Patch I proposed can easily be modified to do that. With my current system
> in mind, currently my patch will split each queue to 8 (on 8 node numa).
> With the change each queue will be split to 160. Currently my libfuse fix
> will start 8 threads and bind one to each NUMA node, now it will have to
> start 160 and bind them to cpus. If you prefer to see some numbers I can
> modify the patch and run some tests.
Okay. Though, as I said, I'd first like to see just some small part
changed e.g. just per-CPU queues, with the background accounting left
alone. Yeah, that will probably not improve async read performance as
well as you like since per-CPU queues are fundamentally about
synchronous requests.
> Chances of processes migrating to different NUMA node is minimum. So I
> didn't modify fuse header to carry a queue id. In the worst case where the
> worker thread gets migrated to different NUMA node my fix will scan all
> split queues till it find the request. But if we split the queues to per
> cpu, there is a high chance that processes migrate to different cpu's. So I
> think it will benefit that I add cpuid to the fuse in/out headers.
Yes, but lets start simple. Just do per-CPU queues and see what it
does in different workloads. Obviously it will regress in some cases,
that's fine. We can then see if the direction is good and the
regressions can be fixed or if it's a completely wrong approach.
Thanks,
Miklos
next prev parent reply other threads:[~2013-05-01 9:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 6:17 FUSE: fixes to improve scalability on NUMA systems Srinivas Eeda
2013-04-30 6:17 ` [PATCH 1/3] fuse: add numa mount option Srinivas Eeda
2013-04-30 6:17 ` [PATCH 2/3] fuse: add fuse numa node struct Srinivas Eeda
2013-04-30 6:17 ` [PATCH 3/3] fuse: split fuse queues to help numa systems Srinivas Eeda
2013-04-30 16:29 ` [fuse-devel] FUSE: fixes to improve scalability on NUMA systems Miklos Szeredi
2013-04-30 18:28 ` Srinivas Eeda
2013-05-01 9:53 ` Miklos Szeredi [this message]
[not found] ` <CAJfpegvi=Npv1Da2gqDb50xWzO4GHusbrwZMn5tUp8hQ89AJjQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-05-08 9:11 ` Anand Avati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegvi=Npv1Da2gqDb50xWzO4GHusbrwZMn5tUp8hQ89AJjQ@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=Nikolaus@rath.org \
--cc=anand.avati@gmail.com \
--cc=fuse-devel@lists.sourceforge.net \
--cc=hanwenn@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=srinivas.eeda@oracle.com \
--cc=stefan@space.twc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).