From: Miklos Szeredi <miklos@szeredi.hu>
To: yangyun <yangyun50@huawei.com>
Cc: josef@toxicpanda.com, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] fuse: replace fuse_queue_forget with fuse_force_forget if error
Date: Thu, 22 Aug 2024 17:26:01 +0200 [thread overview]
Message-ID: <CAJfpegviwk5F+39Vz2D4UjLaGpsFZ-26WeDwetjL=hWV4T6S7A@mail.gmail.com> (raw)
In-Reply-To: <20240727100556.1225580-1-yangyun50@huawei.com>
On Sat, 27 Jul 2024 at 12:06, yangyun <yangyun50@huawei.com> wrote:
> Since forget is not necessarily synchronous (In my opinion, the pre-this patch use of
> synchronous 'fuse_force_forget' is an error case and also not necessarily synchronous),
> what about just changing the 'fuse_force_forget' to be asynchronous?
Even less impact would be to move the allocation inside
fuse_force_forget (make it GFP_NOFAIL) and still use the
fuse_queue_forget() function to send the forget as e.g. virtiofs
handles them differently from regular requests.
Thanks,
Miklos
next prev parent reply other threads:[~2024-08-22 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 8:37 [PATCH 0/2] fuse: add no forget support yangyun
2024-07-26 8:37 ` [PATCH 1/2] fuse: replace fuse_queue_forget with fuse_force_forget if error yangyun
2024-07-26 15:39 ` Josef Bacik
2024-07-27 10:05 ` yangyun
2024-08-22 15:26 ` Miklos Szeredi [this message]
2024-08-23 11:58 ` yangyun
2024-07-26 8:37 ` [PATCH 2/2] fuse: add support for no forget requests yangyun
2024-07-26 15:40 ` Josef Bacik
2024-07-27 10:08 ` yangyun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJfpegviwk5F+39Vz2D4UjLaGpsFZ-26WeDwetjL=hWV4T6S7A@mail.gmail.com' \
--to=miklos@szeredi.hu \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yangyun50@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).