From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9C5DC433F5 for ; Thu, 7 Oct 2021 07:44:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4AAF610C8 for ; Thu, 7 Oct 2021 07:44:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240462AbhJGHpz (ORCPT ); Thu, 7 Oct 2021 03:45:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240448AbhJGHpy (ORCPT ); Thu, 7 Oct 2021 03:45:54 -0400 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [IPv6:2607:f8b0:4864:20::e2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C8A0C061746 for ; Thu, 7 Oct 2021 00:44:01 -0700 (PDT) Received: by mail-vs1-xe2d.google.com with SMTP id x192so3537973vsx.5 for ; Thu, 07 Oct 2021 00:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=J5MitxDy+0H9+Hdt9WDFvZicHxHGsD1a80GgYOJsjVg=; b=c6lI7pFqiczF2Ff2onEgRJQw9MJ5EyY4HgiVZI+81mj4MhCxupIgf8uI0rlm/EWL4j ac5eVhn+M6gxDI06/kXAhmcEXcv3IZve/52m5P5/oRGkp8yHbor4ZtcYvxGxgVLXjWgh i8A37sO1Unf8qWKg7QKOJn4wP+FOMfAO/VYW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=J5MitxDy+0H9+Hdt9WDFvZicHxHGsD1a80GgYOJsjVg=; b=kXU/Ms14jH6yTd+QWBsPjdCzv7S0R59UysADcpA6CcaOMcm3o64wc4g2KmDYdIFoPm joLgFZdaJiob2316CAXiLS25Ve7qaCiuLq0EY7IojA2bnEZwdCc1dAyAYoaYKFAhZT0F 2v3Xdf2CHejS03gobuXk6KG6Le4Av6mNglMAC8dMm3CrO/KUUHE+sd14h9I6YpRVHpzn JYQglviHRKr3bqsaHNjEhlV/nyJ0Bzm45rrqWy4W30u9UOAMv6XT8J5o8bZnainfTF86 WTHT+5mtEZoJHgHjEAsDH+Qe/ahH1EdO2f6h8Po5ygvgDq2A4UmHPVWZWmvexrGfJ+/G smag== X-Gm-Message-State: AOAM533uz4sAAz1gxvg1LLtAKFQOcjW3RrXHkmu57Ax5h+6t7PRsglYE rKczWHQwOdfL3yXyvsbNdbU9kdoipu7oZkuqSzEVpQ== X-Google-Smtp-Source: ABdhPJyQUTZ7iKY7lhTqtwDlpw3BaQP5aBddRrEU6QGr6+JxHsPfkaB8dfwIPwU+g/bWDbJ0zaHltLE9xPgcmKvPS50= X-Received: by 2002:a05:6102:370c:: with SMTP id s12mr2672780vst.42.1633592640623; Thu, 07 Oct 2021 00:44:00 -0700 (PDT) MIME-Version: 1.0 References: <20210923130814.140814-1-cgxu519@mykernel.net> <20210923130814.140814-4-cgxu519@mykernel.net> In-Reply-To: From: Miklos Szeredi Date: Thu, 7 Oct 2021 09:43:49 +0200 Message-ID: Subject: Re: [RFC PATCH v5 03/10] ovl: implement overlayfs' ->evict_inode operation To: Chengguang Xu Cc: Chengguang Xu , Jan Kara , Amir Goldstein , linux-fsdevel@vger.kernel.org, overlayfs , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, 7 Oct 2021 at 08:08, Chengguang Xu wrote: > > =E5=9C=A8 2021/10/6 23:33, Miklos Szeredi =E5=86=99=E9=81=93: > > On Thu, 23 Sept 2021 at 15:08, Chengguang Xu wro= te: > >> Implement overlayfs' ->evict_inode operation, > >> so that we can clear dirty flags of overlayfs inode. > >> > >> Signed-off-by: Chengguang Xu > >> --- > >> fs/overlayfs/super.c | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c > >> index 51886ba6130a..2ab77adf7256 100644 > >> --- a/fs/overlayfs/super.c > >> +++ b/fs/overlayfs/super.c > >> @@ -406,11 +406,18 @@ static int ovl_remount(struct super_block *sb, i= nt *flags, char *data) > >> return ret; > >> } > >> > >> +static void ovl_evict_inode(struct inode *inode) > >> +{ > >> + inode->i_state &=3D ~I_DIRTY_ALL; > >> + clear_inode(inode); > > clear_inode() should already clear the dirty flags; the default > > eviction should work fine without having to define an ->evict_inode. > > What am I missing? > > Yeah, you are right, we don't need overlayfs' own ->evict_inode anymore > > because we wait all writeback upper inodes in overlayfs' ->sync_fs. Okay, I dropped this patch then. Thanks, Miklos