[PATCH 0/4] fuse: use true,false for bool variable

linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/4] fuse: use true,false for bool variable
@ 2019-12-25  3:02 zhengbin
  2019-12-25  3:02 ` [PATCH 1/4] fuse: use true,false for bool variable in readdir.c zhengbin
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: zhengbin @ 2019-12-25  3:02 UTC (permalink / raw)
  To: mszeredi, linux-fsdevel; +Cc: zhengbin13

zhengbin (4):
  fuse: use true,false for bool variable in readdir.c
  fuse: use true,false for bool variable in file.c
  fuse: use true,false for bool variable in cuse.c
  fuse: use true,false for bool variable in inode.c

 fs/fuse/cuse.c    |  4 ++--
 fs/fuse/file.c    |  4 ++--
 fs/fuse/inode.c   | 14 +++++++-------
 fs/fuse/readdir.c |  2 +-
 4 files changed, 12 insertions(+), 12 deletions(-)

--
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/4] fuse: use true,false for bool variable in readdir.c
  2019-12-25  3:02 [PATCH 0/4] fuse: use true,false for bool variable zhengbin
@ 2019-12-25  3:02 ` zhengbin
  2019-12-25  3:02 ` [PATCH 2/4] fuse: use true,false for bool variable in file.c zhengbin
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-25  3:02 UTC (permalink / raw)
  To: mszeredi, linux-fsdevel; +Cc: zhengbin13

Fixes coccicheck warning:

fs/fuse/readdir.c:335:1-19: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/fuse/readdir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/readdir.c b/fs/fuse/readdir.c
index 6a40f75..90e3f01 100644
--- a/fs/fuse/readdir.c
+++ b/fs/fuse/readdir.c
@@ -332,7 +332,7 @@ static int fuse_readdir_uncached(struct file *file, struct dir_context *ctx)
 		return -ENOMEM;

 	plus = fuse_use_readdirplus(inode, ctx);
-	ap->args.out_pages = 1;
+	ap->args.out_pages = true;
 	ap->num_pages = 1;
 	ap->pages = &page;
 	ap->descs = &desc;
--
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/4] fuse: use true,false for bool variable in file.c
  2019-12-25  3:02 [PATCH 0/4] fuse: use true,false for bool variable zhengbin
  2019-12-25  3:02 ` [PATCH 1/4] fuse: use true,false for bool variable in readdir.c zhengbin
@ 2019-12-25  3:02 ` zhengbin
  2019-12-25  3:02 ` [PATCH 3/4] fuse: use true,false for bool variable in cuse.c zhengbin
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-25  3:02 UTC (permalink / raw)
  To: mszeredi, linux-fsdevel; +Cc: zhengbin13

Fixes coccicheck warning:

fs/fuse/file.c:1398:2-19: WARNING: Assignment of 0/1 to bool variable
fs/fuse/file.c:1400:2-20: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/fuse/file.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index a63d779..16205a0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1395,9 +1395,9 @@ static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,
 	}

 	if (write)
-		ap->args.in_pages = 1;
+		ap->args.in_pages = true;
 	else
-		ap->args.out_pages = 1;
+		ap->args.out_pages = true;

 	*nbytesp = nbytes;

--
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/4] fuse: use true,false for bool variable in cuse.c
  2019-12-25  3:02 [PATCH 0/4] fuse: use true,false for bool variable zhengbin
  2019-12-25  3:02 ` [PATCH 1/4] fuse: use true,false for bool variable in readdir.c zhengbin
  2019-12-25  3:02 ` [PATCH 2/4] fuse: use true,false for bool variable in file.c zhengbin
@ 2019-12-25  3:02 ` zhengbin
  2019-12-25  3:02 ` [PATCH 4/4] fuse: use true,false for bool variable in inode.c zhengbin
  2020-01-14 10:02 ` [PATCH 0/4] fuse: use true,false for bool variable Miklos Szeredi
  4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-25  3:02 UTC (permalink / raw)
  To: mszeredi, linux-fsdevel; +Cc: zhengbin13

Fixes coccicheck warning:

fs/fuse/cuse.c:454:1-20: WARNING: Assignment of 0/1 to bool variable
fs/fuse/cuse.c:455:1-19: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/fuse/cuse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c
index 00015d8..030f094 100644
--- a/fs/fuse/cuse.c
+++ b/fs/fuse/cuse.c
@@ -451,8 +451,8 @@ static int cuse_send_init(struct cuse_conn *cc)
 	ap->args.out_args[0].size = sizeof(ia->out);
 	ap->args.out_args[0].value = &ia->out;
 	ap->args.out_args[1].size = CUSE_INIT_INFO_MAX;
-	ap->args.out_argvar = 1;
-	ap->args.out_pages = 1;
+	ap->args.out_argvar = true;
+	ap->args.out_pages = true;
 	ap->num_pages = 1;
 	ap->pages = &ia->page;
 	ap->descs = &ia->desc;
--
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 4/4] fuse: use true,false for bool variable in inode.c
  2019-12-25  3:02 [PATCH 0/4] fuse: use true,false for bool variable zhengbin
                   ` (2 preceding siblings ...)
  2019-12-25  3:02 ` [PATCH 3/4] fuse: use true,false for bool variable in cuse.c zhengbin
@ 2019-12-25  3:02 ` zhengbin
  2020-01-14 10:02 ` [PATCH 0/4] fuse: use true,false for bool variable Miklos Szeredi
  4 siblings, 0 replies; 6+ messages in thread
From: zhengbin @ 2019-12-25  3:02 UTC (permalink / raw)
  To: mszeredi, linux-fsdevel; +Cc: zhengbin13

Fixes coccicheck warning:

fs/fuse/inode.c:497:2-17: WARNING: Assignment of 0/1 to bool variable
fs/fuse/inode.c:504:2-23: WARNING: Assignment of 0/1 to bool variable
fs/fuse/inode.c:511:2-22: WARNING: Assignment of 0/1 to bool variable
fs/fuse/inode.c:518:2-23: WARNING: Assignment of 0/1 to bool variable
fs/fuse/inode.c:522:2-26: WARNING: Assignment of 0/1 to bool variable
fs/fuse/inode.c:526:2-18: WARNING: Assignment of 0/1 to bool variable
fs/fuse/inode.c:1000:1-20: WARNING: Assignment of 0/1 to bool variable

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/fuse/inode.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 16aec32..77fef29 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -494,36 +494,36 @@ static int fuse_parse_param(struct fs_context *fc, struct fs_parameter *param)

 	case OPT_FD:
 		ctx->fd = result.uint_32;
-		ctx->fd_present = 1;
+		ctx->fd_present = true;
 		break;

 	case OPT_ROOTMODE:
 		if (!fuse_valid_type(result.uint_32))
 			return invalf(fc, "fuse: Invalid rootmode");
 		ctx->rootmode = result.uint_32;
-		ctx->rootmode_present = 1;
+		ctx->rootmode_present = true;
 		break;

 	case OPT_USER_ID:
 		ctx->user_id = make_kuid(fc->user_ns, result.uint_32);
 		if (!uid_valid(ctx->user_id))
 			return invalf(fc, "fuse: Invalid user_id");
-		ctx->user_id_present = 1;
+		ctx->user_id_present = true;
 		break;

 	case OPT_GROUP_ID:
 		ctx->group_id = make_kgid(fc->user_ns, result.uint_32);
 		if (!gid_valid(ctx->group_id))
 			return invalf(fc, "fuse: Invalid group_id");
-		ctx->group_id_present = 1;
+		ctx->group_id_present = true;
 		break;

 	case OPT_DEFAULT_PERMISSIONS:
-		ctx->default_permissions = 1;
+		ctx->default_permissions = true;
 		break;

 	case OPT_ALLOW_OTHER:
-		ctx->allow_other = 1;
+		ctx->allow_other = true;
 		break;

 	case OPT_MAX_READ:
@@ -997,7 +997,7 @@ void fuse_send_init(struct fuse_conn *fc)
 	/* Variable length argument used for backward compatibility
 	   with interface version < 7.5.  Rest of init_out is zeroed
 	   by do_get_request(), so a short reply is not a problem */
-	ia->args.out_argvar = 1;
+	ia->args.out_argvar = true;
 	ia->args.out_args[0].size = sizeof(ia->out);
 	ia->args.out_args[0].value = &ia->out;
 	ia->args.force = true;
--
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/4] fuse: use true,false for bool variable
  2019-12-25  3:02 [PATCH 0/4] fuse: use true,false for bool variable zhengbin
                   ` (3 preceding siblings ...)
  2019-12-25  3:02 ` [PATCH 4/4] fuse: use true,false for bool variable in inode.c zhengbin
@ 2020-01-14 10:02 ` Miklos Szeredi
  4 siblings, 0 replies; 6+ messages in thread
From: Miklos Szeredi @ 2020-01-14 10:02 UTC (permalink / raw)
  To: zhengbin; +Cc: Miklos Szeredi, linux-fsdevel

On Wed, Dec 25, 2019 at 3:55 AM zhengbin <zhengbin13@huawei.com> wrote:
>
> zhengbin (4):
>   fuse: use true,false for bool variable in readdir.c
>   fuse: use true,false for bool variable in file.c
>   fuse: use true,false for bool variable in cuse.c
>   fuse: use true,false for bool variable in inode.c
>
>  fs/fuse/cuse.c    |  4 ++--
>  fs/fuse/file.c    |  4 ++--
>  fs/fuse/inode.c   | 14 +++++++-------
>  fs/fuse/readdir.c |  2 +-
>  4 files changed, 12 insertions(+), 12 deletions(-)

Hi,

Could you please merge these four patches into one?

The patches are trivial and even the combined patch is tiny, so it's
not worth splitting it by source file.

Thanks,
Miklos

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-01-14 10:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-25  3:02 [PATCH 0/4] fuse: use true,false for bool variable zhengbin
2019-12-25  3:02 ` [PATCH 1/4] fuse: use true,false for bool variable in readdir.c zhengbin
2019-12-25  3:02 ` [PATCH 2/4] fuse: use true,false for bool variable in file.c zhengbin
2019-12-25  3:02 ` [PATCH 3/4] fuse: use true,false for bool variable in cuse.c zhengbin
2019-12-25  3:02 ` [PATCH 4/4] fuse: use true,false for bool variable in inode.c zhengbin
2020-01-14 10:02 ` [PATCH 0/4] fuse: use true,false for bool variable Miklos Szeredi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).