From: Miklos Szeredi <miklos@szeredi.hu>
To: Stan Hu <stanhu@gmail.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: overlay2: backporting a copy_file_range bug fix in Linux 5.6 to 5.10?
Date: Thu, 2 Dec 2021 20:37:31 +0100 [thread overview]
Message-ID: <CAJfpegvsiW-UsnhSrbQ2X0JpLAppUy3+WaNnzFrPwrKCmg82Fg@mail.gmail.com> (raw)
In-Reply-To: <CAMBWrQnfGuMjF6pQfoj9U5abKBQpaYtSH11QFo4+jZrL32XUEg@mail.gmail.com>
On Wed, 1 Dec 2021 at 22:31, Stan Hu <stanhu@gmail.com> wrote:
>
> A number of users have reported that under certain conditions using
> Docker and overlay2, copy_file_range() can unexpectedly create a
> 0-byte file: In https://github.com/docker/for-linux/issues/1015.
>
> We started seeing mysterious failures in our CI tests as a result of
> files not properly being copied.
>
> https://github.com/docker/for-linux/issues/1015#issuecomment-841915668
> has a sample reproduction test.
>
> I analyzed the diff between 5.10 and 5.11 and found that if I applied
> the following kernel patch, the reproduction test passes:
>
> https://lore.kernel.org/linux-fsdevel/20201207163255.564116-6-mszeredi@redhat.com/#t
>
> This landed in this merge commit and this commit:
>
> 1. https://github.com/torvalds/linux/commit/92dbc9dedccb9759c7f9f2f0ae6242396376988f
> 2. https://github.com/torvalds/linux/commit/82a763e61e2b601309d696d4fa514c77d64ee1be
>
> Could this patch be backported for kernels 5.6 to 5.10?
Yes, looks like the patch can be backported.
Note: you also need to backport this commit which is a fix for the first one:
9b91b6b019fd ("ovl: fix deadlock in splice write")
Thanks,
Miklos
next prev parent reply other threads:[~2021-12-02 19:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 21:30 overlay2: backporting a copy_file_range bug fix in Linux 5.6 to 5.10? Stan Hu
2021-12-02 19:37 ` Miklos Szeredi [this message]
2021-12-04 7:15 ` Amir Goldstein
2021-12-04 7:25 ` Stan Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegvsiW-UsnhSrbQ2X0JpLAppUy3+WaNnzFrPwrKCmg82Fg@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stanhu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).