linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Xie Yongji <xieyongji@bytedance.com>
Cc: linux-fsdevel@vger.kernel.org, zhangjiachen.jaycee@bytedance.com
Subject: Re: [RFC] fuse: Avoid invalidating attrs if writeback_cache enabled
Date: Mon, 11 Oct 2021 15:21:13 +0200	[thread overview]
Message-ID: <CAJfpegvw2F_WbTAk_f92YwBn3YwqbG3Ond74DY7yvMbzeUnMKA@mail.gmail.com> (raw)
In-Reply-To: <20211011090240.97-1-xieyongji@bytedance.com>

On Mon, 11 Oct 2021 at 11:07, Xie Yongji <xieyongji@bytedance.com> wrote:
>
> Recently we found the performance of small direct writes is bad
> when writeback_cache enabled. This is because we need to get
> attrs from userspace in fuse_update_get_attr() on each write.
> The timeout for the attributes doesn't work since every direct write
> will invalidate the attrs in fuse_direct_IO().
>
> To fix it, this patch tries to avoid invalidating attrs if writeback_cache
> is enabled since we should trust local size/ctime/mtime in this case.

Hi,

Thanks for the patch.

Just pushed an update to
git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.gitt#for-next
(9ca3f8697158 ("fuse: selective attribute invalidation")) that should
fix this behavior.

Could you please test?

Thanks,
Miklos

  reply	other threads:[~2021-10-11 13:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11  9:02 [RFC] fuse: Avoid invalidating attrs if writeback_cache enabled Xie Yongji
2021-10-11 13:21 ` Miklos Szeredi [this message]
2021-10-11 14:45   ` Yongji Xie
2021-10-13 13:52     ` Miklos Szeredi
2021-10-18 11:25       ` Yongji Xie
2021-10-18 11:45         ` Miklos Szeredi
2021-10-18 13:08           ` Yongji Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpegvw2F_WbTAk_f92YwBn3YwqbG3Ond74DY7yvMbzeUnMKA@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xieyongji@bytedance.com \
    --cc=zhangjiachen.jaycee@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).