From: Joanne Koong <joannelkoong@gmail.com>
To: Chunsheng Luo <luochunsheng@ustc.edu>
Cc: bernd.schubert@fastmail.fm, jefflexu@linux.alibaba.com,
kernel-team@meta.com, linux-fsdevel@vger.kernel.org,
miklos@szeredi.hu, willy@infradead.org
Subject: Re: [PATCH] fuse: enable large folios (if writeback cache is unused)
Date: Tue, 12 Aug 2025 15:14:36 -0700 [thread overview]
Message-ID: <CAJnrk1ZAZm3ayvRu_6Ke-ByHrRSP6rAsrZHzUMLmOFfCSyBUvw@mail.gmail.com> (raw)
In-Reply-To: <20250812032538.2734-1-luochunsheng@ustc.edu>
On Mon, Aug 11, 2025 at 8:26 PM Chunsheng Luo <luochunsheng@ustc.edu> wrote:
>
> On Mon, Aug 11, 2025 Joanne Koong <joannelkoong@gmail.com> wrote:
> >>
> >> Large folios are only enabled if the writeback cache isn't on.
> >> (Strictlimiting needs to be turned off if the writeback cache is used in
> >> conjunction with large folios, else this tanks performance.)
> >
> > Some ideas for having this work with the writeback cache are
> > a) add a fuse sysctl sysadmins can set to turn off strictlimiting for
> > all fuse servers mounted after, in the kernel turn on large folios for
> > writeback if that sysctl is on
> > b) if the fuse server is privileged automatically turn off
> > strictlimiting and enable large folios for writeback
> >
> > Any thoughts?
>
> Should large folios be enabled based on mount options? Consider adding an
> option in fuse_init_out to explicitly turn on large folios.
>
Hi Chunsheng,
Personally I'm not a fan of doing it through the init request because
it is tied hand-in-hand with disabling strictlimiting (which requires
admin privileges) and imo
a) it feels clunky that the user needs to opt into it for writeback
(for non-writeback cases, ideally large folios are the status quo) and
then also find the bdi that corresponds to that fuse mount, then go
into /sys/class/bdi/* for that bdi to disable strictlimiting, all
while making sure this happens before write workloads start
b) I think users (who most are not familiar with kernel internals)
will likely be confused by what large folios are and whether/when they
should opt into it or not
imo if the fuse server is mounted as a privileged server, I think it's
reasonable that strictlimiting could be turned off by default.
Thanks,
Joanne
> Thanks
> Chunsheng Luo
next prev parent reply other threads:[~2025-08-12 22:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 20:40 [PATCH] fuse: enable large folios (if writeback cache is unused) Joanne Koong
2025-08-11 21:13 ` Joanne Koong
2025-08-12 3:25 ` Chunsheng Luo
2025-08-12 22:14 ` Joanne Koong [this message]
2025-08-12 11:13 ` Miklos Szeredi
2025-08-12 19:38 ` Darrick J. Wong
2025-08-12 23:02 ` Joanne Koong
2025-08-13 1:20 ` Darrick J. Wong
2025-08-13 17:40 ` Joanne Koong
2025-08-13 8:20 ` Miklos Szeredi
2025-08-13 18:05 ` Joanne Koong
2025-08-12 22:44 ` Joanne Koong
2025-08-15 11:01 ` Jingbo Xu
2025-08-15 16:16 ` Joanne Koong
2025-08-16 1:45 ` Jingbo Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJnrk1ZAZm3ayvRu_6Ke-ByHrRSP6rAsrZHzUMLmOFfCSyBUvw@mail.gmail.com \
--to=joannelkoong@gmail.com \
--cc=bernd.schubert@fastmail.fm \
--cc=jefflexu@linux.alibaba.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luochunsheng@ustc.edu \
--cc=miklos@szeredi.hu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).