Re: [PATCH v2 7/8] fuse: refactor setting up copy state for payload copying

[Joanne Koong <joannelkoong@gmail.com>]

On Thu, Nov 6, 2025 at 8:53 AM Bernd Schubert <bschubert@ddn.com> wrote:
>
> On 10/27/25 23:28, Joanne Koong wrote:
> > Add a new helper function setup_fuse_copy_state() to contain the logic
> > for setting up the copy state for payload copying.
> >
> > Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
> > ---
> >  fs/fuse/dev_uring.c | 39 +++++++++++++++++++++++++--------------
> >  1 file changed, 25 insertions(+), 14 deletions(-)
> >
> > diff --git a/fs/fuse/dev_uring.c b/fs/fuse/dev_uring.c
> > index c814b571494f..c6b22b14b354 100644
> > --- a/fs/fuse/dev_uring.c
> > +++ b/fs/fuse/dev_uring.c
> > @@ -630,6 +630,28 @@ static int copy_header_from_ring(struct fuse_ring_ent *ent,
> >       return 0;
> >  }
> >
> > +static int setup_fuse_copy_state(struct fuse_ring *ring, struct fuse_req *req,
> > +                              struct fuse_ring_ent* ent, int rw,
> > +                              struct iov_iter *iter,
> > +                              struct fuse_copy_state *cs)
>
> Maybe 'struct fuse_copy_state *cs' as first argument? Just a suggestion and would
> good if it wouldn't end up in the middle when there are more arguments added at some
> point.
>
I like your suggestion a lot, I think that makes it clearer to read
too :) I'll reorder this to be the first arg. Thanks!