From: Joanne Koong <joannelkoong@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, djwong@kernel.org,
anuj1072538@gmail.com, miklos@szeredi.hu, brauner@kernel.org,
linux-xfs@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH v2 09/16] iomap: change 'count' to 'async_writeback'
Date: Mon, 16 Jun 2025 11:49:29 -0700 [thread overview]
Message-ID: <CAJnrk1a934dLVLjUo2hy1jTo4B6xcj4ODMRb_YO8aM7CfquUfg@mail.gmail.com> (raw)
In-Reply-To: <aFATg58omJ2405xC@infradead.org>
On Mon, Jun 16, 2025 at 5:52 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Fri, Jun 13, 2025 at 02:46:34PM -0700, Joanne Koong wrote:
> > Rename "count" to "async_writeback" to better reflect its function and
> > since it is used as a boolean, change its type from unsigned to bool.
>
> Not sure async_writeback is really the right name here, the way it is
> used is just that there is any writeback going on. Which generally
> is asynchronous as otherwise performance would suck, but the important
> bit is that the responsibility for finishing the folio writeback shifted
> to the caller.
I like your name "wb_pending" a lot better.
next prev parent reply other threads:[~2025-06-16 18:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 21:46 [PATCH v2 00/16] fuse: use iomap for buffered writes + writeback Joanne Koong
2025-06-13 21:46 ` [PATCH v2 01/16] iomap: move buffered io CONFIG_BLOCK dependent logic into separate file Joanne Koong
2025-06-13 21:46 ` [PATCH v2 02/16] iomap: iomap_read_folio_sync() -> iomap_bio_read_folio_sync() Joanne Koong
2025-06-13 21:46 ` [PATCH v2 03/16] iomap: iomap_add_to_ioend() -> iomap_bio_add_to_ioend() Joanne Koong
2025-06-13 21:46 ` [PATCH v2 04/16] iomap: add wrapper function iomap_bio_readpage() Joanne Koong
2025-06-16 12:49 ` Christoph Hellwig
2025-06-16 19:18 ` Joanne Koong
2025-06-17 4:38 ` Christoph Hellwig
2025-06-17 17:20 ` Joanne Koong
2025-06-18 4:45 ` Christoph Hellwig
2025-06-18 19:17 ` Joanne Koong
2025-06-23 7:42 ` Christoph Hellwig
2025-06-23 20:53 ` Joanne Koong
2025-06-13 21:46 ` [PATCH v2 05/16] iomap: add wrapper function iomap_bio_ioend_error() Joanne Koong
2025-06-13 21:46 ` [PATCH v2 06/16] iomap: add wrapper function iomap_submit_bio() Joanne Koong
2025-06-13 21:46 ` [PATCH v2 07/16] iomap: decouple buffered-io.o from CONFIG_BLOCK Joanne Koong
2025-06-13 21:46 ` [PATCH v2 08/16] iomap: add read_folio_sync() handler for buffered writes Joanne Koong
2025-06-13 21:46 ` [PATCH v2 09/16] iomap: change 'count' to 'async_writeback' Joanne Koong
2025-06-16 12:52 ` Christoph Hellwig
2025-06-16 18:49 ` Joanne Koong [this message]
2025-06-13 21:46 ` [PATCH v2 10/16] iomap: replace ->map_blocks() with generic ->writeback_folio() for writeback Joanne Koong
2025-06-16 12:54 ` Christoph Hellwig
2025-06-13 21:46 ` [PATCH v2 11/16] iomap: replace ->submit_ioend() with generic ->writeback_complete() " Joanne Koong
2025-06-13 21:46 ` [PATCH v2 12/16] iomap: support more customized writeback handling Joanne Koong
2025-06-13 21:46 ` [PATCH v2 13/16] iomap: add iomap_writeback_dirty_folio() Joanne Koong
2025-06-13 21:46 ` [PATCH v2 14/16] fuse: use iomap for buffered writes Joanne Koong
2025-06-13 21:46 ` [PATCH v2 15/16] fuse: use iomap for writeback Joanne Koong
2025-06-13 21:46 ` [PATCH v2 16/16] fuse: use iomap for folio laundering Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJnrk1a934dLVLjUo2hy1jTo4B6xcj4ODMRb_YO8aM7CfquUfg@mail.gmail.com \
--to=joannelkoong@gmail.com \
--cc=anuj1072538@gmail.com \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).