From: Haris Iqbal <haris.iqbal@ionos.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
Jack Wang <jinpu.wang@ionos.com>
Subject: Re: [PATCH 07/32] rnbd-srv: Convert to use blkdev_get_handle_by_path()
Date: Wed, 12 Jul 2023 17:54:06 +0200 [thread overview]
Message-ID: <CAJpMwyg-+rKk_2-1bhN5M9pdYiCNusbfe2B+PA1cNOp1uwNJGg@mail.gmail.com> (raw)
In-Reply-To: <20230704122224.16257-7-jack@suse.cz>
On Tue, Jul 4, 2023 at 2:22 PM Jan Kara <jack@suse.cz> wrote:
>
> Convert rnbd-srv to use blkdev_get_handle_by_path() and pass the handle
> around.
>
> CC: Jack Wang <jinpu.wang@ionos.com>
> CC: "Md. Haris Iqbal" <haris.iqbal@ionos.com>
> Signed-off-by: Jan Kara <jack@suse.cz>
Acked-by: "Md. Haris Iqbal" <haris.iqbal@ionos.com>
Thanks
> ---
> drivers/block/rnbd/rnbd-srv.c | 28 +++++++++++++++-------------
> drivers/block/rnbd/rnbd-srv.h | 2 +-
> 2 files changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
> index c186df0ec641..606db77c1238 100644
> --- a/drivers/block/rnbd/rnbd-srv.c
> +++ b/drivers/block/rnbd/rnbd-srv.c
> @@ -145,7 +145,7 @@ static int process_rdma(struct rnbd_srv_session *srv_sess,
> priv->sess_dev = sess_dev;
> priv->id = id;
>
> - bio = bio_alloc(sess_dev->bdev, 1,
> + bio = bio_alloc(sess_dev->bdev_handle->bdev, 1,
> rnbd_to_bio_flags(le32_to_cpu(msg->rw)), GFP_KERNEL);
> if (bio_add_page(bio, virt_to_page(data), datalen,
> offset_in_page(data)) != datalen) {
> @@ -219,7 +219,7 @@ void rnbd_destroy_sess_dev(struct rnbd_srv_sess_dev *sess_dev, bool keep_id)
> rnbd_put_sess_dev(sess_dev);
> wait_for_completion(&dc); /* wait for inflights to drop to zero */
>
> - blkdev_put(sess_dev->bdev, NULL);
> + blkdev_handle_put(sess_dev->bdev_handle);
> mutex_lock(&sess_dev->dev->lock);
> list_del(&sess_dev->dev_list);
> if (!sess_dev->readonly)
> @@ -534,7 +534,7 @@ rnbd_srv_get_or_create_srv_dev(struct block_device *bdev,
> static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
> struct rnbd_srv_sess_dev *sess_dev)
> {
> - struct block_device *bdev = sess_dev->bdev;
> + struct block_device *bdev = sess_dev->bdev_handle->bdev;
>
> rsp->hdr.type = cpu_to_le16(RNBD_MSG_OPEN_RSP);
> rsp->device_id = cpu_to_le32(sess_dev->device_id);
> @@ -559,7 +559,7 @@ static void rnbd_srv_fill_msg_open_rsp(struct rnbd_msg_open_rsp *rsp,
> static struct rnbd_srv_sess_dev *
> rnbd_srv_create_set_sess_dev(struct rnbd_srv_session *srv_sess,
> const struct rnbd_msg_open *open_msg,
> - struct block_device *bdev, bool readonly,
> + struct bdev_handle *handle, bool readonly,
> struct rnbd_srv_dev *srv_dev)
> {
> struct rnbd_srv_sess_dev *sdev = rnbd_sess_dev_alloc(srv_sess);
> @@ -571,7 +571,7 @@ rnbd_srv_create_set_sess_dev(struct rnbd_srv_session *srv_sess,
>
> strscpy(sdev->pathname, open_msg->dev_name, sizeof(sdev->pathname));
>
> - sdev->bdev = bdev;
> + sdev->bdev_handle = handle;
> sdev->sess = srv_sess;
> sdev->dev = srv_dev;
> sdev->readonly = readonly;
> @@ -676,7 +676,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> struct rnbd_srv_dev *srv_dev;
> struct rnbd_srv_sess_dev *srv_sess_dev;
> const struct rnbd_msg_open *open_msg = msg;
> - struct block_device *bdev;
> + struct bdev_handle *bdev_handle;
> blk_mode_t open_flags = BLK_OPEN_READ;
> char *full_path;
> struct rnbd_msg_open_rsp *rsp = data;
> @@ -714,15 +714,16 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> goto reject;
> }
>
> - bdev = blkdev_get_by_path(full_path, open_flags, NULL, NULL);
> - if (IS_ERR(bdev)) {
> - ret = PTR_ERR(bdev);
> + bdev_handle = blkdev_get_handle_by_path(full_path, open_flags, NULL,
> + NULL);
> + if (IS_ERR(bdev_handle)) {
> + ret = PTR_ERR(bdev_handle);
> pr_err("Opening device '%s' on session %s failed, failed to open the block device, err: %d\n",
> full_path, srv_sess->sessname, ret);
> goto free_path;
> }
>
> - srv_dev = rnbd_srv_get_or_create_srv_dev(bdev, srv_sess,
> + srv_dev = rnbd_srv_get_or_create_srv_dev(bdev_handle->bdev, srv_sess,
> open_msg->access_mode);
> if (IS_ERR(srv_dev)) {
> pr_err("Opening device '%s' on session %s failed, creating srv_dev failed, err: %ld\n",
> @@ -731,7 +732,8 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> goto blkdev_put;
> }
>
> - srv_sess_dev = rnbd_srv_create_set_sess_dev(srv_sess, open_msg, bdev,
> + srv_sess_dev = rnbd_srv_create_set_sess_dev(srv_sess, open_msg,
> + bdev_handle,
> open_msg->access_mode == RNBD_ACCESS_RO,
> srv_dev);
> if (IS_ERR(srv_sess_dev)) {
> @@ -747,7 +749,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> */
> mutex_lock(&srv_dev->lock);
> if (!srv_dev->dev_kobj.state_in_sysfs) {
> - ret = rnbd_srv_create_dev_sysfs(srv_dev, bdev);
> + ret = rnbd_srv_create_dev_sysfs(srv_dev, bdev_handle->bdev);
> if (ret) {
> mutex_unlock(&srv_dev->lock);
> rnbd_srv_err(srv_sess_dev,
> @@ -790,7 +792,7 @@ static int process_msg_open(struct rnbd_srv_session *srv_sess,
> }
> rnbd_put_srv_dev(srv_dev);
> blkdev_put:
> - blkdev_put(bdev, NULL);
> + blkdev_handle_put(bdev_handle);
> free_path:
> kfree(full_path);
> reject:
> diff --git a/drivers/block/rnbd/rnbd-srv.h b/drivers/block/rnbd/rnbd-srv.h
> index 1027656dedb0..343cc682b617 100644
> --- a/drivers/block/rnbd/rnbd-srv.h
> +++ b/drivers/block/rnbd/rnbd-srv.h
> @@ -46,7 +46,7 @@ struct rnbd_srv_dev {
> struct rnbd_srv_sess_dev {
> /* Entry inside rnbd_srv_dev struct */
> struct list_head dev_list;
> - struct block_device *bdev;
> + struct bdev_handle *bdev_handle;
> struct rnbd_srv_session *sess;
> struct rnbd_srv_dev *dev;
> struct kobject kobj;
> --
> 2.35.3
>
next prev parent reply other threads:[~2023-07-12 15:54 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 12:21 [PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle Jan Kara
2023-07-04 12:21 ` [PATCH 01/32] block: Provide blkdev_get_handle_* functions Jan Kara
2023-07-04 12:43 ` Matthew Wilcox
2023-07-04 13:03 ` Jan Kara
2023-07-04 14:06 ` Bart Van Assche
2023-07-04 16:14 ` Matthew Wilcox
2023-07-05 15:19 ` Bart Van Assche
2023-07-05 16:12 ` Jan Kara
2023-07-04 16:28 ` Keith Busch
2023-07-05 10:21 ` Jan Kara
2023-07-06 15:38 ` Christoph Hellwig
2023-07-06 16:14 ` Jan Kara
2023-07-07 11:28 ` Christoph Hellwig
2023-07-07 12:24 ` Jan Kara
2023-07-12 16:06 ` Haris Iqbal
2023-07-31 10:50 ` Jan Kara
2023-07-31 11:13 ` Christoph Hellwig
2023-07-04 12:21 ` [PATCH 02/32] block: Use file->f_flags for determining exclusive opens in file_to_blk_mode() Jan Kara
2023-07-06 15:35 ` Christoph Hellwig
2023-07-06 16:35 ` Jan Kara
2023-07-07 11:29 ` Christoph Hellwig
2023-07-04 12:21 ` [PATCH 03/32] block: Use blkdev_get_handle_by_dev() in blkdev_open() Jan Kara
2023-07-05 5:05 ` Kanchan Joshi
2023-07-05 10:17 ` Jan Kara
2023-07-04 12:21 ` [PATCH 04/32] block: Use blkdev_get_handle_by_dev() in disk_scan_partitions() and blkdev_bszset() Jan Kara
2023-07-04 12:21 ` [PATCH 05/32] drdb: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 06/32] pktcdvd: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 07/32] rnbd-srv: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-12 15:54 ` Haris Iqbal [this message]
2023-07-04 12:21 ` [PATCH 08/32] xen/blkback: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 09/32] zram: Convert to use blkdev_get_handle_by_dev() Jan Kara
2023-07-05 0:52 ` Sergey Senozhatsky
2023-07-04 12:21 ` [PATCH 10/32] bcache: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 13:06 ` Coly Li
2023-07-04 12:21 ` [PATCH 11/32] dm: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 12/32] md: " Jan Kara
2023-07-04 12:21 ` [PATCH 13/32] mtd: block2mtd: Convert to blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 14/32] nvmet: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 15/32] s390/dasd: " Jan Kara
2023-07-04 12:21 ` [PATCH 16/32] scsi: target: " Jan Kara
2023-07-04 12:21 ` [PATCH 17/32] PM: hibernate: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 18/32] PM: hibernate: Drop unused snapshot_test argument Jan Kara
2023-07-04 12:21 ` [PATCH 19/32] mm/swap: Convert to use blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 20/32] fs: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 21/32] btrfs: " Jan Kara
2023-07-04 12:21 ` [PATCH 22/32] erofs: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-06 15:16 ` Gao Xiang
2023-07-04 12:21 ` [PATCH 23/32] ext4: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-04 12:21 ` [PATCH 24/32] f2fs: Convert to blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 25/32] jfs: Convert to blkdev_get_handle_by_dev() Jan Kara
2023-07-05 15:16 ` Dave Kleikamp
2023-07-04 12:21 ` [PATCH 26/32] nfs/blocklayout: Convert to use blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 27/32] nilfs2: Convert to use blkdev_get_handle_by_path() Jan Kara
2023-07-21 5:22 ` Ryusuke Konishi
2023-07-04 12:21 ` [PATCH 28/32] ocfs2: Convert to use blkdev_get_handle_by_dev() Jan Kara
2023-07-05 10:55 ` Joseph Qi
2023-07-04 12:21 ` [PATCH 29/32] reiserfs: Convert to blkdev_get_handle_by_dev/path() Jan Kara
2023-07-04 12:21 ` [PATCH 30/32] xfs: Convert to blkdev_get_handle_by_path() Jan Kara
2023-07-04 12:21 ` [PATCH 31/32] block: Remove blkdev_get_by_*() functions Jan Kara
2023-07-04 12:21 ` [PATCH 32/32] block: Rename blkdev_get_handle_by_*() and blkdev_handle_put() Jan Kara
2023-07-06 14:54 ` [PATCH RFC 0/32] block: Make blkdev_get_by_*() return handle Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJpMwyg-+rKk_2-1bhN5M9pdYiCNusbfe2B+PA1cNOp1uwNJGg@mail.gmail.com \
--to=haris.iqbal@ionos.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jinpu.wang@ionos.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).