From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA0F612CD9D for ; Mon, 26 Feb 2024 17:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708967612; cv=none; b=Dh9V2zTe26RH/Hp8I4WMjbYNhZWBc7KODTPPjxBTNIBhLfH1WadaLyjOJvSQs9usLAcf7brjmQp8OVVm30bHiGVbwJRCjcpW77+/XdOQ0HKQsf/Q4RsTjbIQXBGE4DRbgV7DoxFA+S4whJDLmQJKlRZold2T3jUyhRTqJ8OAD28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708967612; c=relaxed/simple; bh=EyV42V4YwospafBlBP85zlF0CzzIrV0ckGMLg38+cps=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VeJRAn6LiJP0y1GurzXmzwVexY/Y4r7PD91HHAUb5AnJVLhQ48rjeDjOdI3fmVS3ONgNczYvfBPThz9EjGEk75TxVTM5rzUY38LcTi4136Po+ILOrslY7sfa8gPz1WEI8rU9q/Vg3G0sG4LSAiXnprSCbe/8tS2qoiu4xRNML2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=0fViydWZ; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="0fViydWZ" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-6087d1355fcso18240237b3.0 for ; Mon, 26 Feb 2024 09:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708967609; x=1709572409; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EyV42V4YwospafBlBP85zlF0CzzIrV0ckGMLg38+cps=; b=0fViydWZafBwJ3xL0F3ZTuvRSwyOFSrmHfEq0669FdAat5dooHz4w4ydcwe76KJq26 LLK1Innl8Ozcr4ZzRFS8wOBZXfz8XVvIsM1Lpl41+dDr0LuROfLdG53dNGlA9b9h4eMF G1BrAsi2HgrrmZVytsbBCN43zN48wzi+DBMamTdoOdAkkld+5uUZGlksQA++8+kDhnB4 8YisjaPtufsIlwnzZjkqcK4rgrYZZUtUJ6qGAZVZozShNglx+FJnTn12ouCxp4XPVmkD /ODSKBsJ4q/ATs5/nmT5Fa36KV2ZLF/J1cucEBLoNSKhvXKtX5V2YN3O0AKtgJFesZaz HUSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708967610; x=1709572410; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EyV42V4YwospafBlBP85zlF0CzzIrV0ckGMLg38+cps=; b=FpQWh2vaqXExsUGDNlwwwc3/h7G6+QD2gl/CbKeNja1wUDy5DoauMjjxDjNGPNkIM3 b7Xl2begNsyV59gpCmQuY4MO/R4xU7Ot3USEHuAJf0yoWjZ509qxX94D3ZuRfbtfcnnm y871c1zzujxSGGleRkUpAFNC0YH6vqJNfXk9UvwZVSbK8knic3I9fhIV/PYQ+I/bgKoa NmjLx8Nnxmx8tGWFFuf5HnmfCeuNjVI4HkcZJSoo/oEz5c0Wx9Qi4bfcqk4ynELP2+ax XzEybAL0KA7R47UXWV9ud8gqOFls0t8OrH8llXMmb4TH3WzJAmFRY/3cchgnkt/w4+kI XwKg== X-Forwarded-Encrypted: i=1; AJvYcCUxfS/JStAiiEgqYB46QRU4gWWFVMvTrDI69a+4JQpmf4w2nZMwKoaMwqopyA8N+lkDoWTrAr9Nu9ctE+WV+EyvleQ33FbepS1pKyQB9g== X-Gm-Message-State: AOJu0YwAb2Y/xYoX81Ad4EaxpyJvvXeOQROBKTbCngfxvhJOKqWhdj3/ D1cp/xi7XmIp7P7f6H0tiDlSfwK9aQgqsmkywk0fFQ7NjRP+f5OOSLZFDTiNIqVhpSbmwGkMmk0 wXoPTAUeC6gSu1rEn9jk6tCIguMHDnHWqn0kS X-Google-Smtp-Source: AGHT+IE/7/pQws6CVfL30UNt1mkliSDpCczaElkub3hA0YpEAm7Kcwht1trOE3ZU3RPvAg7BLiFgI/3lAi1UqBVzgIg= X-Received: by 2002:a05:6902:210e:b0:dcd:1f17:aaea with SMTP id dk14-20020a056902210e00b00dcd1f17aaeamr6639276ybb.26.1708967608014; Mon, 26 Feb 2024 09:13:28 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-14-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Mon, 26 Feb 2024 09:13:17 -0800 Message-ID: Subject: Re: [PATCH v4 13/36] lib: prevent module unloading if memory is not freed To: Vlastimil Babka Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 26, 2024 at 8:58=E2=80=AFAM Vlastimil Babka wr= ote: > > On 2/21/24 20:40, Suren Baghdasaryan wrote: > > Skip freeing module's data section if there are non-zero allocation tag= s > > because otherwise, once these allocations are freed, the access to thei= r > > code tag would cause UAF. > > > > Signed-off-by: Suren Baghdasaryan > > I know that module unloading was never considered really supported etc. > But should we printk something so the admin knows why it didn't unload, a= nd > can go check those outstanding allocations? Yes, that sounds reasonable. I'll add a pr_warn() in the next version. Thanks! > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >