linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Suren Baghdasaryan <surenb@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: akpm@linux-foundation.org, mhocko@suse.com, mcgrof@kernel.org,
	keescook@chromium.org, yzaikin@google.com,
	dave.hansen@linux.intel.com, vbabka@suse.cz,
	mgorman@techsingularity.net, corbet@lwn.net, yi.zhang@huawei.com,
	xi.fengfei@h3c.com, rppt@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	kernel-team@android.com
Subject: Re: [PATCH 1/1] sysctl: change watermark_scale_factor max limit to 30%
Date: Wed, 24 Nov 2021 14:04:28 -0800	[thread overview]
Message-ID: <CAJuCfpGP3ZdeqfYZJ6SUCdnputU-sEOsNYx5Pd9ckL1-zuWC2w@mail.gmail.com> (raw)
In-Reply-To: <YZ6wg9A5p5WUy7+k@cmpxchg.org>

On Wed, Nov 24, 2021 at 1:37 PM Johannes Weiner <hannes@cmpxchg.org> wrote:
>
> On Wed, Nov 24, 2021 at 11:36:04AM -0800, Suren Baghdasaryan wrote:
> > For embedded systems with low total memory, having to run applications
> > with relatively large memory requirements, 10% max limitation for
> > watermark_scale_factor poses an issue of triggering direct reclaim
> > every time such application is started. This results in slow application
> > startup times and bad end-user experience.
> > By increasing watermark_scale_factor max limit we allow vendors more
> > flexibility to choose the right level of kswapd aggressiveness for
> > their device and workload requirements.
> >
> > Signed-off-by: Suren Baghdasaryan <surenb@google.com>
>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>

Thanks!

>
> No objection from me as this limit was always totally arbitrary. But I
> have to say I'm a bit surprised: The current maximum setting will wake
> kswapd when free memory drops below 10% and have it reclaim until
> 20%. This seems like quite a lot? Are there applications that really
> want kswapd to wake at 30% and target 60% of memory free?

The example I was given by a vendor was Camera application requiring
0.25G on 1GB device. Camera apps are notoriously memory hungry on
Android and on low-memory devices it can require more than 20% of
total memory to run.

      reply	other threads:[~2021-11-24 22:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 19:36 [PATCH 1/1] sysctl: change watermark_scale_factor max limit to 30% Suren Baghdasaryan
2021-11-24 21:37 ` Johannes Weiner
2021-11-24 22:04   ` Suren Baghdasaryan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJuCfpGP3ZdeqfYZJ6SUCdnputU-sEOsNYx5Pd9ckL1-zuWC2w@mail.gmail.com \
    --to=surenb@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=keescook@chromium.org \
    --cc=kernel-team@android.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=xi.fengfei@h3c.com \
    --cc=yi.zhang@huawei.com \
    --cc=yzaikin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).