From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289BCC433FE for ; Tue, 12 Oct 2021 17:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1368961076 for ; Tue, 12 Oct 2021 17:01:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232018AbhJLRDT (ORCPT ); Tue, 12 Oct 2021 13:03:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229810AbhJLRDT (ORCPT ); Tue, 12 Oct 2021 13:03:19 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 548E2C061745 for ; Tue, 12 Oct 2021 10:01:17 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id s4so48117746ybs.8 for ; Tue, 12 Oct 2021 10:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8Tzhl0MVFy9A0j1rnPsvy8YVR9B6G5UsH8EyCGPBclE=; b=ZcOenQ6fVRLLsv/XeQFPg7fnM5YEM500n89LF22NH+zpMwjIeByGZnUmUhodoBeu4+ uwRWuao0Tu++R3OlxtP+LKtt7vSGIzR7JzZAOoRYt2nrsggm63sKqt5bHG4YydOI6rbz EWfFpyddnUNjAcDMQdF8LgCWLuUDazezQTw7gQy9qtJAntsZUsYobnzegylDiaOMGwOI MDxq8+Dre7QZRyI4jvrs5HJwdVG78mh5+2eIvdkY04GLC9IKL1K9rD+9U39CrRpRZfZ+ 85bzsQZhzLNXmWkU4iZojVd4u4SE2SIV3Kygv4OxuhiD5x9Uo9VVm0sv7jo2p7b5oW5u 1ctg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8Tzhl0MVFy9A0j1rnPsvy8YVR9B6G5UsH8EyCGPBclE=; b=m4GavRBGIWY0wjiFRGa8/vwITbe/o3vMQMxuHsdlifyPigsCgX0vKGbdFmu9UgfF60 nn6zqLhB9Oxgdogz9opwl9YoVSzwaLo0wAtr/+vyLGcBaVuVNtZxJcEz8ipmKGuZIdhx 8HvA0RLYY7SdAeD4NQ06pA78+7aYjiLjwdM4ZE6Tj2qxCZUMWy9mOcMPY7aGzn9hd2op W3vUBAZDEc25YCCSquCuo9/FRYJLydPDwN+OqJwGsS7J5lXxl47z2etKgdKFOP+1LcBm tMn0qMuvBOG91H6M2zd5em9DVHm9Wm9OJ89zDzh8af2tMJcXxKwdS1IbtA9VebzG8DyC rHWA== X-Gm-Message-State: AOAM531KhLe8ce36yveeRLI8Kaguz6LOXpAXijYbXGMj1AOUqJc4MGdB fU0WlXDva+uxTOzv5rScUCfjAvJdSp0XXgog8hvdhQ== X-Google-Smtp-Source: ABdhPJwOPTX5trcDK3fnE5j1KylJQjqxL9bNX71uZKloGBWhRHQA8xA+zeQh1Ynbd9I628/FnTZxa/rbysY+VRcBD8Y= X-Received: by 2002:a25:552:: with SMTP id 79mr28537708ybf.202.1634058076286; Tue, 12 Oct 2021 10:01:16 -0700 (PDT) MIME-Version: 1.0 References: <92cbfe3b-f3d1-a8e1-7eb9-bab735e782f6@rasmusvillemoes.dk> <20211007101527.GA26288@duo.ucw.cz> <202110071111.DF87B4EE3@keescook> <202110081344.FE6A7A82@keescook> <26f9db1e-69e9-1a54-6d49-45c0c180067c@redhat.com> In-Reply-To: <26f9db1e-69e9-1a54-6d49-45c0c180067c@redhat.com> From: Suren Baghdasaryan Date: Tue, 12 Oct 2021 10:01:05 -0700 Message-ID: Subject: Re: [PATCH v10 3/3] mm: add anonymous vma name refcounting To: David Hildenbrand Cc: Michal Hocko , Kees Cook , Pavel Machek , Rasmus Villemoes , John Hubbard , Andrew Morton , Colin Cross , Sumit Semwal , Dave Hansen , Matthew Wilcox , "Kirill A . Shutemov" , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Al Viro , Randy Dunlap , Kalesh Singh , Peter Xu , rppt@kernel.org, Peter Zijlstra , Catalin Marinas , vincenzo.frascino@arm.com, =?UTF-8?B?Q2hpbndlbiBDaGFuZyAo5by16Yym5paHKQ==?= , Axel Rasmussen , Andrea Arcangeli , Jann Horn , apopple@nvidia.com, Yu Zhao , Will Deacon , fenghua.yu@intel.com, thunder.leizhen@huawei.com, Hugh Dickins , feng.tang@intel.com, Jason Gunthorpe , Roman Gushchin , Thomas Gleixner , krisman@collabora.com, Chris Hyser , Peter Collingbourne , "Eric W. Biederman" , Jens Axboe , legion@kernel.org, Rolf Eike Beer , Cyrill Gorcunov , Muchun Song , Viresh Kumar , Thomas Cedeno , sashal@kernel.org, cxfcosmos@gmail.com, LKML , linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm , kernel-team Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Oct 12, 2021 at 12:44 AM David Hildenbrand wrote: > > > I'm still evaluating the proposal to use memfds but I'm not sure if > > the issue that David Hildenbrand mentioned about additional memory > > consumed in pagecache (which has to be addressed) is the only one we > > will encounter with this approach. If anyone knows of any potential > > issues with using memfds as named anonymous memory, I would really > > appreciate your feedback before I go too far in that direction. > > [MAP_PRIVATE memfd only behave that way with 4k, not with huge pages, so > I think it just has to be fixed. It doesn't make any sense to allocate a > page for the pagecache ("populate the file") when accessing via a > private mapping that's supposed to leave the file untouched] > > My gut feeling is if you really need a string as identifier, then try > going with memfds. Yes, we might hit some road blocks to be sorted out, > but it just logically makes sense to me: Files have names. These names > exist before mapping and after mapping. They "name" the content. I'm investigating this direction. I don't have much background with memfds, so I'll need to digest the code first. > > Maybe it's just me, but the whole interface, setting the name via a > prctl after the mapping was already instantiated doesn't really spark > joy at my end. That's not a strong pushback, but if we can avoid it > using something that's already there, that would be very much preferred. Actually that's one of my worries about using memfds. There might be cases when we need to name a vma after it was mapped. memfd_create() would not allow us to do that AFAIKT. But I need to check all usages to say if that's really an issue. Thanks! > > -- > Thanks, > > David / dhildenb > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >