From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADD651C13 for ; Tue, 13 Feb 2024 02:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707790829; cv=none; b=VZBoOdxB2RVQodMXCjsGRbhJuO4PRqvj3gloq3Pr8f287JOSNj+3b2qhC+uWMs9z8DCBtOzC/GvT2bYjQuQGHNrjxkF8GmX+HwvNmoUSL2XPxwBqgXxdiBRVW5ESDMQWS+hrw2mMbm7xYMeg5aHeq2n+0QyT5tjXUhs9mGSoDOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707790829; c=relaxed/simple; bh=S9sbRuvYiarABejv+1FZRtHjtyC1exllh7yCDkk639Q=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=AJ6h8pJGEMabsRJpca0N6gSgLc0cLePvMDIlmabAly/F+8LgWfmG53DHfk/Rj72UooSRhpaPl8rpfhleZGGnvKhcS98xyDawCUUAkKAHjJ0rMQyoeEjh1wOzJY9wSmUiZUM9Q2tE+D0vRD2rT8bMofgbGmUhzFhiPacupyxEzUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=4Jrb9xtg; arc=none smtp.client-ip=209.85.219.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="4Jrb9xtg" Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-dbed179f0faso3416153276.1 for ; Mon, 12 Feb 2024 18:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707790825; x=1708395625; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S9sbRuvYiarABejv+1FZRtHjtyC1exllh7yCDkk639Q=; b=4Jrb9xtgZZd68Cd8qtWKkms3W8lyscetML+GV9VkniajxjX00oCm8vO3er0J1tOJYG KXV6U73T7/ahxivChBXpV+Epa+r+05A2t154aRf14aPl3XbChON6p22PKWX4U7vAzS9o brwAToX8177IfGEf9W+XIqe1YPvjrVvfL9p54qZ1sWP3PGzpzREqC3UGYZKQKBZySG2k Ww0YUiGkRHSadsneVBJVnVGSj/Fif1gMg/8vv70xOYtj2wcjiPng2kr+bKGBZYgVzATG OKxyy6fQiAVrWs5pOrlgKVY84DYPBwXY7IoUnb6KCj+HNchnZ6OPi4x27n09k46FAdxz ByRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707790825; x=1708395625; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S9sbRuvYiarABejv+1FZRtHjtyC1exllh7yCDkk639Q=; b=kinC0ghp7/Hd0Hwqep0SNi5R6Rnx9KgmcbSWAdB+r8WfdzEggN0tyWM6AeZ0Fi/26X YCyFUMvuY7qpDz6xmozSEcNT3sAHGuK2FZw/oqBVVGVIsRG0dYnIdqoMlosQf0byMtsG NwM/wMnz1v9jVYsA34Wjyh3HYOz9ndL7p9gRuuLG4o+2hJ3dopA+K1KovuxLHv8V0jqz lb8a8dyrLg/+ajB+Ve8s9pG5JkZ1FcpecgQAju4sfJkQzfFwtbcQp0eku/xolRziQU+u 67ocFpBudmsVVrxCYBhq3zCB5sRY1f3agSP+mn+LtCcwoB2eMWVvVDssAW6t1tlNP8pN g9/Q== X-Gm-Message-State: AOJu0YyJ4CLCX+o+mRUgnRX7zfxFfKLlEINuIbkzcgqM+y/pr62VbRHb 4NroeRG4uqczasOrsETfbLOGW2UOd34oP7OzTj3uEzMOCGPxKaX7kN9+m6evfAdBEbCQrmrwI3i gLbOly05B7aYAH6c5xxdrTJkPcqlSB5R78k1I X-Google-Smtp-Source: AGHT+IF7VIKyAprzsQj97Z263Qoier3okujGUFo7m34RyS9jjnxf5dSV3vlCD/UI6jUXKLUqELRXLl2excxB7HnDSlw= X-Received: by 2002:a25:df91:0:b0:dc6:de93:7929 with SMTP id w139-20020a25df91000000b00dc6de937929mr863370ybg.26.1707790825358; Mon, 12 Feb 2024 18:20:25 -0800 (PST) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-6-surenb@google.com> <202402121413.94791C74D5@keescook> In-Reply-To: <202402121413.94791C74D5@keescook> From: Suren Baghdasaryan Date: Mon, 12 Feb 2024 18:20:13 -0800 Message-ID: Subject: Re: [PATCH v3 05/35] mm: introduce slabobj_ext to support slab object extensions To: Kees Cook Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Feb 12, 2024 at 2:14=E2=80=AFPM Kees Cook w= rote: > > On Mon, Feb 12, 2024 at 01:38:51PM -0800, Suren Baghdasaryan wrote: > > Currently slab pages can store only vectors of obj_cgroup pointers in > > page->memcg_data. Introduce slabobj_ext structure to allow more data > > to be stored for each slab object. Wrap obj_cgroup into slabobj_ext > > to support current functionality while allowing to extend slabobj_ext > > in the future. > > > > Signed-off-by: Suren Baghdasaryan > > It looks like this doesn't change which buckets GFP_KERNEL_ACCOUNT comes > out of, is that correct? I'd love it if we didn't have separate buckets > so GFP_KERNEL and GFP_KERNEL_ACCOUNT came from the same pools (so that > the randomized pools would cover GFP_KERNEL_ACCOUNT ...) This should not affect KMEM accounting in any way. We are simply changing the vector of obj_cgroup objects to hold complex objects which can contain more fields in addition to the original obj_cgroup (in our case it's the codetag reference). Unless I misunderstood your question? > > Regardless: > > Reviewed-by: Kees Cook > > -- > Kees Cook