From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13991132C09 for ; Tue, 26 Mar 2024 07:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711439499; cv=none; b=FGSdqJM60D+ynp2cNvRwYHCiABfcyMD2xuKMCctoWLcPPSDhGP/l85c/4HGjabfLRA4yka3Nu+6Mnq/Q6KQ/mC4kOE1kYkUIzwVSDU/7t2NCK2WE0AJV2HVTjJTT8ADkC8MugbVj3Ar/snAXhOE11FtKnJdRO4i6Sa48c94jt4M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711439499; c=relaxed/simple; bh=qQOLO5yzYREaf6V5UZ46t3ExCwuenEVvpk1QDbdYz28=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=rJ2gR4Sjws94MZweiTSbZ4OM+SIraWk8aIQZ9f6gWOkmmuT08RQE67Zk/k5wdA/zpStRCcI2bXypqLevlkX3L1JegDZ6WMGXrewXc1RI4u4rFXZTMSpnbpIbgMBjAFzNV1FEQBW1MIn80zIVjCR6uikhlnYYZ4yUCgkTmAcw3Bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AoR/K3A9; arc=none smtp.client-ip=209.85.219.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AoR/K3A9" Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-dcc80d6004bso5109638276.0 for ; Tue, 26 Mar 2024 00:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711439495; x=1712044295; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=shklYWkLA2oyBqnlJsmv6lUxL/P85ZOYE2ckd/gba5w=; b=AoR/K3A9wZgTr/H35zji2Ryw+JLZD17t8Szk3uZ0qBgeAWIMB4NN/BJPJl3JEUN120 JR/dFikYMYTHog58UqZeWY3abyXSZUyAQhcJeeiKJpnr/q3iy4u2x+ZiWRmiFXTuY4d0 +wc6Q4UTQkI1gwn3NZpEbigkgcPaUHuCPwDkFXgLpseEsrvifg9T5Hl2k2OELRZjb6IO 7HhpJaXTkfsKZer7xANqdvBDRaIHRAYTWZTqNzDY69XWEL0E6/FXTCmnffr7tHBlV5uz EdplvUVUqmH07En2kwV6V3HDpPDo4hp6r0Czwxmv6qUgkvmaDs7Irw3eU/uoAoJFXx2u w+jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711439495; x=1712044295; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=shklYWkLA2oyBqnlJsmv6lUxL/P85ZOYE2ckd/gba5w=; b=a0NRjS5sOlpe47h823WvzWfIjiGX7YHb970aqoj6dk8fuzZVBa5potRt+x67Nxlev3 YlIhWCr+H2b55rKy+8kegsADviYAiqnyhql6BqXs4QMQynSAiIgmrRnT+FihxVhQCBtt TTDR2HV3BOKJVGDV/S+wkdB2ZJWtbPvuR9JXDeG19CLPA6/oWDHculuvnY3UD6PsOSxu hK0ZEw02RrsPSm5tubBTzFesFgeicTbHLftXDljoiyw67AeX5I31yPHM48ClxtBT8LtF wu3zBElutW0Z5OhMC+86ci0epzaQoLupb9e58FMc4cXQlLOA+6IxbJNtoVFuAyJ+x2Wg KCyg== X-Forwarded-Encrypted: i=1; AJvYcCWuHfKiohHJ7eO/gmBcYqkYjzOkhlT6q0i93C9d8SCR19DXtcE1V6oEhr+zTQHl1yMl3u7GLBPp1Xuobp7F6gXKSp64i8tnm1QVJKQP/w== X-Gm-Message-State: AOJu0Ywz+/ZsODG7zE/lZIPWUIYSsku0QISvw2ZvZhgFS+p+VWE0J/QN tADWGz7808tKiV5Mkdx5bdj2WlDEyRAxcDWl1KP+XSgWjdZWl4bfcoPgi8QoCItec132nP0BdPJ rUqZ9K9NkFYvaen12zWtjqMT42R6RcY918Qkq X-Google-Smtp-Source: AGHT+IEnVh4+gbIjqfTqnNSb1ESniynB5/g+eF5Tlrl382kaRHENtFyyuE83hIP6W791lwHTf2P908O7iGBHbxnvUiU= X-Received: by 2002:a5b:181:0:b0:dce:2e9:a637 with SMTP id r1-20020a5b0181000000b00dce02e9a637mr7603025ybl.20.1711439494844; Tue, 26 Mar 2024 00:51:34 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240325182007.233780-1-sj@kernel.org> In-Reply-To: <20240325182007.233780-1-sj@kernel.org> From: Suren Baghdasaryan Date: Tue, 26 Mar 2024 00:51:21 -0700 Message-ID: Subject: Re: [PATCH v6 30/37] mm: vmalloc: Enable memory allocation profiling To: SeongJae Park Cc: vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 25, 2024 at 11:20=E2=80=AFAM SeongJae Park wrot= e: > > On Mon, 25 Mar 2024 10:59:01 -0700 Suren Baghdasaryan = wrote: > > > On Mon, Mar 25, 2024 at 10:49=E2=80=AFAM SeongJae Park = wrote: > > > > > > On Mon, 25 Mar 2024 14:56:01 +0000 Suren Baghdasaryan wrote: > > > > > > > On Sat, Mar 23, 2024 at 6:05=E2=80=AFPM SeongJae Park wrote: > > > > > > > > > > Hi Suren and Kent, > > > > > > > > > > On Thu, 21 Mar 2024 09:36:52 -0700 Suren Baghdasaryan wrote: > > > > > > > > > > > From: Kent Overstreet > > > > > > > > > > > > This wrapps all external vmalloc allocation functions with the > > > > > > alloc_hooks() wrapper, and switches internal allocations to _no= prof > > > > > > variants where appropriate, for the new memory allocation profi= ling > > > > > > feature. > > > > > > > > > > I just noticed latest mm-unstable fails running kunit on my machi= ne as below. > > > > > 'git-bisect' says this is the first commit of the failure. > > > > > > > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out= / > > > > > [10:59:53] Configuring KUnit Kernel ... > > > > > [10:59:53] Building KUnit Kernel ... > > > > > Populating config with: > > > > > $ make ARCH=3Dum O=3D../kunit.out/ olddefconfig > > > > > Building with: > > > > > $ make ARCH=3Dum O=3D../kunit.out/ --jobs=3D36 > > > > > ERROR:root:/usr/bin/ld: arch/um/os-Linux/main.o: in function = `__wrap_malloc': > > > > > main.c:(.text+0x10b): undefined reference to `vmalloc' > > > > > collect2: error: ld returned 1 exit status > > > > > > > > > > Haven't looked into the code yet, but reporting first. May I ask= your idea? > > > > > > > > Hi SeongJae, > > > > Looks like we missed adding "#include " inside > > > > arch/um/os-Linux/main.c in this patch: > > > > https://lore.kernel.org/all/20240321163705.3067592-2-surenb@google.= com/. > > > > I'll be posing fixes for all 0-day issues found over the weekend an= d > > > > will include a fix for this. In the meantime, to work around it you > > > > can add that include yourself. Please let me know if the issue stil= l > > > > persists after doing that. > > > > > > Thank you, Suren. The change made the error message disappears. How= ever, it > > > introduced another one. > > > > Ok, let me investigate and I'll try to get a fix for it today evening. > > Thank you for this kind reply. Nonetheless, this is not blocking some re= al > thing from me. So, no rush. Plese take your time :) I posted a fix here: https://lore.kernel.org/all/20240326073750.726636-1-surenb@google.com/ Please let me know if this resolves the issue. Thanks, Suren. > > > Thanks, > SJ > > > Thanks, > > Suren. > > > > > > > > $ git diff > > > diff --git a/arch/um/os-Linux/main.c b/arch/um/os-Linux/main.c > > > index c8a42ecbd7a2..8fe274e9f3a4 100644 > > > --- a/arch/um/os-Linux/main.c > > > +++ b/arch/um/os-Linux/main.c > > > @@ -16,6 +16,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #define PGD_BOUND (4 * 1024 * 1024) > > > #define STACKSIZE (8 * 1024 * 1024) > > > $ > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > > [10:43:13] Configuring KUnit Kernel ... > > > [10:43:13] Building KUnit Kernel ... > > > Populating config with: > > > $ make ARCH=3Dum O=3D../kunit.out/ olddefconfig > > > Building with: > > > $ make ARCH=3Dum O=3D../kunit.out/ --jobs=3D36 > > > ERROR:root:In file included from .../arch/um/kernel/asm-offsets.c= :1: > > > .../arch/x86/um/shared/sysdep/kernel-offsets.h:9:6: warning: no p= revious prototype for =E2=80=98foo=E2=80=99 [-Wmissing-prototypes] > > > 9 | void foo(void) > > > | ^~~ > > > In file included from .../include/linux/alloc_tag.h:8, > > > from .../include/linux/vmalloc.h:5, > > > from .../arch/um/os-Linux/main.c:19: > > > .../include/linux/bug.h:5:10: fatal error: asm/bug.h: No such fil= e or directory > > > 5 | #include > > > | ^~~~~~~~~~~ > > > compilation terminated. > > > > > > > > > Thanks, > > > SJ > > > > > > [...] > > > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >