From: Suren Baghdasaryan <surenb@google.com>
To: Peter Xu <peterx@redhat.com>
Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com,
lokeshgidra@google.com, david@redhat.com, hughd@google.com,
mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org,
willy@infradead.org, Liam.Howlett@oracle.com, jannh@google.com,
zhangpeng362@huawei.com, bgeffon@google.com,
kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v4 5/5] selftests/mm: add UFFDIO_MOVE ioctl test
Date: Mon, 30 Oct 2023 14:22:15 -0700 [thread overview]
Message-ID: <CAJuCfpHzEn0=6-4sngq8qQ6h5mSM+Gj-4OqOGF=cvefouk1cbw@mail.gmail.com> (raw)
In-Reply-To: <ZUATjxr2i7zVfL8I@x1n>
On Mon, Oct 30, 2023 at 1:35 PM Peter Xu <peterx@redhat.com> wrote:
>
> On Mon, Oct 30, 2023 at 01:22:02PM -0700, Suren Baghdasaryan wrote:
> > > > +static int adjust_page_size(void)
> > > > +{
> > > > + page_size = default_huge_page_size();
> > >
> > > This is hacky too, currently page_size is the real page_size backing the
> > > memory.
> > >
> > > To make thp test simple, maybe just add one more test to MOVE a large chunk
> > > to replace the thp test, which may contain a few thps? It also doesn't
> > > need to be fault based.
> >
> > Sorry, I didn't get your suggestion. Could you please clarify? Which
> > thp test are you referring to?
>
> The new "move-pmd" test.
>
> I meant maybe it makes sense to have one separate MOVE test for when one
> ioctl(MOVE) covers a large range which can cover some thps. Then that will
> trigger thp paths. Assuming the fault paths are already covered in the
> generic "move" test.
Oh, you mean I should not share uffd_move_test() between move and
move-pmd test and have separate logic instead that does not rely on
the page_size overrides? If so then I think that's doable. Some more
code but probably cleaner.
>
> Thanks,
>
> --
> Peter Xu
>
prev parent reply other threads:[~2023-10-30 21:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-28 0:38 [PATCH v4 0/5] userfaultfd move option Suren Baghdasaryan
2023-10-28 0:38 ` [PATCH v4 1/5] mm/rmap: support move to different root anon_vma in folio_move_anon_rmap() Suren Baghdasaryan
2023-10-30 20:15 ` Peter Xu
2023-10-28 0:38 ` [PATCH v4 2/5] userfaultfd: UFFDIO_MOVE uABI Suren Baghdasaryan
2023-10-28 7:43 ` kernel test robot
2023-10-28 0:38 ` [PATCH v4 3/5] selftests/mm: call uffd_test_ctx_clear at the end of the test Suren Baghdasaryan
2023-10-30 20:14 ` Peter Xu
2023-11-02 21:32 ` Axel Rasmussen
2023-10-28 0:38 ` [PATCH v4 4/5] selftests/mm: add uffd_test_case_ops to allow test case-specific operations Suren Baghdasaryan
2023-10-28 0:38 ` [PATCH v4 5/5] selftests/mm: add UFFDIO_MOVE ioctl test Suren Baghdasaryan
2023-10-30 20:14 ` Peter Xu
2023-10-30 20:22 ` Suren Baghdasaryan
2023-10-30 20:35 ` Peter Xu
2023-10-30 21:22 ` Suren Baghdasaryan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJuCfpHzEn0=6-4sngq8qQ6h5mSM+Gj-4OqOGF=cvefouk1cbw@mail.gmail.com' \
--to=surenb@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bgeffon@google.com \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jdduke@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lokeshgidra@google.com \
--cc=mhocko@suse.com \
--cc=ngeoffray@google.com \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).