From: Masahiro Yamada <masahiroy@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Eckert.Florian@googlemail.com
Subject: Re: [PATCH] fs/proc: add compile time info
Date: Thu, 15 Sep 2022 13:37:02 +0900 [thread overview]
Message-ID: <CAK7LNARfQodG3tSYBs7ZAzsbkdwDS0=g=e8qJStfBi3BGut7Fw@mail.gmail.com> (raw)
In-Reply-To: <c8577c14a1663cbdea70534c086c247c@dev.tdt.de>
On Mon, Sep 12, 2022 at 6:42 PM Florian Eckert <fe@dev.tdt.de> wrote:
>
> Hello Masahiro,
>
> thanks for your feedback.
>
> > https://patchwork.kernel.org/project/linux-kbuild/patch/20220828024003.28873-6-masahiroy@kernel.org/
> > lands, nobody cannot reference KBUILD_BUILD_TIMESTAMP,
> > then this whack-a-mole game will end.
>
> I was not aware of that problem. Thanks for the link.
>
> I understood that this is a bad idea to create the timestamp for proc
> like this!
> But how does it look in principle to offer the build timestamp in proc
> for reading?
> You have only made your point about creating the timestamp but not about
> reading it out via the proc directory.
>
> So far the timestamp is only readable as a string via dmesg.
init/version.c is the only file that can depend on the output of
the 'date' command.
You can follow what 'linux_proc_banner' does.
Define it in init/version.c, and declare it somewhere in a header file.
> Best regards
>
> Florian
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2022-09-15 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 11:34 [PATCH] fs/proc: add compile time info Florian Eckert
[not found] ` <CAK7LNAT3cyv07p7AZ54D=HOZRZ7-zLgMM+YPNLzcPidpDvXZgA@mail.gmail.com>
2022-09-12 9:42 ` Florian Eckert
2022-09-15 4:37 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK7LNARfQodG3tSYBs7ZAzsbkdwDS0=g=e8qJStfBi3BGut7Fw@mail.gmail.com' \
--to=masahiroy@kernel.org \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).