From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B0EACD54AF for ; Tue, 19 Sep 2023 11:22:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231246AbjISLWR (ORCPT ); Tue, 19 Sep 2023 07:22:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbjISLWP (ORCPT ); Tue, 19 Sep 2023 07:22:15 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D033F7 for ; Tue, 19 Sep 2023 04:22:09 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bcb50e194dso87776591fa.3 for ; Tue, 19 Sep 2023 04:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; t=1695122527; x=1695727327; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cxr0g9QJnEAuUaDmoar9PC6+7zR9VeOGpFWUhb9wkTE=; b=MzrMZSZN009jYRLJ8bgoAC5wBnuCIMvvhW3xdsvg7/jLVGPAXLIzuKwIi0dKwb2wrc KCKq+h7VS3L8WR8rU1ZbTEwSwbibkIqqEhKGcOuVCKOtPTDcs5LnHL+7Fa80okU8PRjP lNjujLe4vRabFLvueWtPOyObiOsumZpziLmGa4zG6rfBr7/xLEOCZaIfwOhWOK3tr+5q 6k255Bb0TauqdjGuH4VMzezBwfIEm603vj/scJH33rf0fggq1LVwH41zepI40f6OChEj AGPRtLRENMcCYU6d9ocX5KdKEif6IVxtxVXWoMNQtXwAF7YbBXlBJywYBz9lEHC/X8u4 OM/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695122527; x=1695727327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cxr0g9QJnEAuUaDmoar9PC6+7zR9VeOGpFWUhb9wkTE=; b=KkJ8PlPWK8wMg7+CJZOHhJjfJmuQSMdfisTY83YRWMs7m8RDc5k+o9NAT23oOI+qdl 7MRSRaGcwNPpB9pKAzJYPv+AY+DrqamfGMCMNUCtmkC+XOjwG4PJUHwcKd5Ohfiakn7G JEOiPQ2oyo+IplYCNCzChE9UHm0hOJAAvR9nmn8B04YKbTZipVp2NGcqD7wwxCAPAFc5 NOLUh/uU4IGlZWeUAsDVVc1mw/Jj5bLXFGZ3pHdEi4JzajQCzpYNCWPbsddD94ejLKqk R+pbH43nP8pHX/Um74iEMPxSOYmO2vYTD50l05/gNO/9sy8+45IFOFhikPRmhp5NPWVa b+wg== X-Gm-Message-State: AOJu0YzaOTCxNz4XNEJ7gqKKtMGtqKlxjAnxvwzFyfDBsEgrVOQdYf5J 0yiqjEKlFXQ21EVX6+OVBKrVrPp2ow7j7jcSL7nV1g== X-Google-Smtp-Source: AGHT+IHR50NEkB3piP/yQTcJ2TebuvdCdBfzNmIQLZ1SvugIhuCFPmRLnzjBBw/SYuivtE0/hH8GOYzDRWCWTIVKxok= X-Received: by 2002:a2e:3008:0:b0:2c0:2b44:6ebe with SMTP id w8-20020a2e3008000000b002c02b446ebemr1092028ljw.13.1695122527429; Tue, 19 Sep 2023 04:22:07 -0700 (PDT) MIME-Version: 1.0 References: <20230918123217.932179-1-max.kellermann@ionos.com> <20230918123217.932179-3-max.kellermann@ionos.com> <20230918124050.hzbgpci42illkcec@quack3> <20230918142319.kvzc3lcpn5n2ty6g@quack3> <20230919100112.nlb2t4nm46wmugc2@quack3> In-Reply-To: From: Max Kellermann Date: Tue, 19 Sep 2023 13:21:56 +0200 Message-ID: Subject: Re: inotify maintenance status To: Amir Goldstein Cc: Jan Kara , linux-fsdevel , Christian Brauner , Ivan Babrou , Matthew Bobrowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Sep 19, 2023 at 12:59=E2=80=AFPM Amir Goldstein wrote: > Any API complexity can be hidden from users with userspace > libraries. You can use the inotify-tools lib if you prefer. That doesn't convince me at all, but that's a question of taste. We'll just keep using inotify (with a patched kernel, which we have anyway). > > Getting an already-opened file descriptor, or just the file_handle, is > > certainly an interesting fanotify feature. But that could have easily > > been added to inotify with a new "mask" flag for the > > inotify_add_watch() function. > > > > "could have easily been added" is not a statement that I am willing > to accept. Are you willing to take a bet? I come up with a patch for implementing this for inotify, let's say within a week, and you agree to merge it? (I'm not interested in this feature, I won't ever use it - all I wanted is dfd support for inotify_add_watch()). > The things that you are complaining about in the API are the exact > things that were needed to make the advanced features work. Not exactly - I complain that fanotify makes the complexity mandatory, the complexity is the baseline of the API. It would have been possible to design an API that is simple for 99% of all users, as simple as inotify; and only those who need the advanced features get the complexity as an option. I don't agree with your point that unnecessary complexity should be mitigated by throwing more (library) code at it. That's just adding more complexity and more overhead, the opposite of what I want. Max