* [PATCH] fs: exfat: fix improper check of dentry.stream.valid_size
@ 2025-10-14 13:01 Jaehun Gou
2025-10-15 5:39 ` Namjae Jeon
0 siblings, 1 reply; 2+ messages in thread
From: Jaehun Gou @ 2025-10-14 13:01 UTC (permalink / raw)
To: Namjae Jeon
Cc: linux-fsdevel, linux-kernel, Jaehun Gou, Seunghun Han,
Jihoon Kwon
We found an infinite loop bug in the exFAT file system that can lead to a
Denial-of-Service (DoS) condition. When a dentry in an exFAT filesystem is
malformed, the following system calls — SYS_openat, SYS_ftruncate, and
SYS_pwrite64 — can cause the kernel to hang.
Root cause analysis shows that the size validation code in exfat_find()
does not check whether dentry.stream.valid_size is negative. As a result,
the system calls mentioned above can succeed and eventually trigger the DoS
issue.
This patch adds a check for negative dentry.stream.valid_size to prevent
this vulnerability.
Co-developed-by: Seunghun Han <kkamagui@gmail.com>
Signed-off-by: Seunghun Han <kkamagui@gmail.com>
Co-developed-by: Jihoon Kwon <jimmyxyz010315@gmail.com>
Signed-off-by: Jihoon Kwon <jimmyxyz010315@gmail.com>
Signed-off-by: Jaehun Gou <p22gone@gmail.com>
---
fs/exfat/namei.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/fs/exfat/namei.c b/fs/exfat/namei.c
index 7eb9c67fd35f..2364b49f050a 100644
--- a/fs/exfat/namei.c
+++ b/fs/exfat/namei.c
@@ -642,10 +642,14 @@ static int exfat_find(struct inode *dir, const struct qstr *qname,
info->type = exfat_get_entry_type(ep);
info->attr = le16_to_cpu(ep->dentry.file.attr);
- info->size = le64_to_cpu(ep2->dentry.stream.valid_size);
info->valid_size = le64_to_cpu(ep2->dentry.stream.valid_size);
info->size = le64_to_cpu(ep2->dentry.stream.size);
+ if (info->valid_size < 0) {
+ exfat_fs_error(sb, "data valid size is invalid(%lld)", info->valid_size);
+ return -EIO;
+ }
+
if (unlikely(EXFAT_B_TO_CLU_ROUND_UP(info->size, sbi) > sbi->used_clusters)) {
exfat_fs_error(sb, "data size is invalid(%lld)", info->size);
return -EIO;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fs: exfat: fix improper check of dentry.stream.valid_size
2025-10-14 13:01 [PATCH] fs: exfat: fix improper check of dentry.stream.valid_size Jaehun Gou
@ 2025-10-15 5:39 ` Namjae Jeon
0 siblings, 0 replies; 2+ messages in thread
From: Namjae Jeon @ 2025-10-15 5:39 UTC (permalink / raw)
To: Jaehun Gou; +Cc: linux-fsdevel, linux-kernel, Seunghun Han, Jihoon Kwon
On Tue, Oct 14, 2025 at 10:02 PM Jaehun Gou <p22gone@gmail.com> wrote:
>
> We found an infinite loop bug in the exFAT file system that can lead to a
> Denial-of-Service (DoS) condition. When a dentry in an exFAT filesystem is
> malformed, the following system calls — SYS_openat, SYS_ftruncate, and
> SYS_pwrite64 — can cause the kernel to hang.
>
> Root cause analysis shows that the size validation code in exfat_find()
> does not check whether dentry.stream.valid_size is negative. As a result,
> the system calls mentioned above can succeed and eventually trigger the DoS
> issue.
>
> This patch adds a check for negative dentry.stream.valid_size to prevent
> this vulnerability.
>
> Co-developed-by: Seunghun Han <kkamagui@gmail.com>
> Signed-off-by: Seunghun Han <kkamagui@gmail.com>
> Co-developed-by: Jihoon Kwon <jimmyxyz010315@gmail.com>
> Signed-off-by: Jihoon Kwon <jimmyxyz010315@gmail.com>
> Signed-off-by: Jaehun Gou <p22gone@gmail.com>
Applied it to #dev.
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-15 5:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14 13:01 [PATCH] fs: exfat: fix improper check of dentry.stream.valid_size Jaehun Gou
2025-10-15 5:39 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).