[PATCH v1] exfat: fix timing of synchronizing bitmap and inode

[PATCH v1] exfat: fix timing of synchronizing bitmap and inode

[Yuezhang.Mo]

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

Commit(f55c096f62f1 exfat: do not zero the extended part) changed
the timing of synchronizing bitmap and inode in exfat_cont_expand().
The change caused xfstests generic/013 to fail if 'dirsync' or 'sync'
is enabled. So this commit restores the timing.

Fixes: f55c096f62f1 ("exfat: do not zero the extended part")
Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
---
 fs/exfat/file.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 40aa134ad4cb..e067a82ec62a 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -51,7 +51,7 @@ static int exfat_cont_expand(struct inode *inode, loff_t size)
 	clu.flags = ei->flags;
 
 	ret = exfat_alloc_cluster(inode, new_num_clusters - num_clusters,
-			&clu, IS_DIRSYNC(inode));
+			&clu, inode_needs_sync(inode));
 	if (ret)
 		return ret;
 
@@ -75,12 +75,11 @@ static int exfat_cont_expand(struct inode *inode, loff_t size)
 	i_size_write(inode, size);
 
 	inode->i_blocks = round_up(size, sbi->cluster_size) >> 9;
+	mark_inode_dirty(inode);
 
-	if (IS_DIRSYNC(inode))
+	if (IS_SYNC(inode))
 		return write_inode_now(inode, 1);
 
-	mark_inode_dirty(inode);
-
 	return 0;
 
 free_clu:
-- 
2.34.1

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v1-0001-exfat-fix-timing-of-synchronizing-bitmap-and-inod.patch --]
[-- Type: text/x-patch; name="v1-0001-exfat-fix-timing-of-synchronizing-bitmap-and-inod.patch", Size: 1427 bytes --]

From c155bda0ba189b3d2bf873e64086b23a07c78ac4 Mon Sep 17 00:00:00 2001
From: Yuezhang Mo <Yuezhang.Mo@sony.com>
Date: Fri, 22 Mar 2024 17:52:19 +0800
Subject: [PATCH v1] exfat: fix timing of synchronizing bitmap and inode

Commit(f55c096f62f1 exfat: do not zero the extended part) changed
the timing of synchronizing bitmap and inode in exfat_cont_expand().
The change caused xfstests generic/013 to fail if 'dirsync' or 'sync'
is enabled. So this commit restores the timing.

Fixes: f55c096f62f1 ("exfat: do not zero the extended part")
Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
---
 fs/exfat/file.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/exfat/file.c b/fs/exfat/file.c
index 40aa134ad4cb..e067a82ec62a 100644
--- a/fs/exfat/file.c
+++ b/fs/exfat/file.c
@@ -51,7 +51,7 @@ static int exfat_cont_expand(struct inode *inode, loff_t size)
 	clu.flags = ei->flags;
 
 	ret = exfat_alloc_cluster(inode, new_num_clusters - num_clusters,
-			&clu, IS_DIRSYNC(inode));
+			&clu, inode_needs_sync(inode));
 	if (ret)
 		return ret;
 
@@ -75,12 +75,11 @@ static int exfat_cont_expand(struct inode *inode, loff_t size)
 	i_size_write(inode, size);
 
 	inode->i_blocks = round_up(size, sbi->cluster_size) >> 9;
+	mark_inode_dirty(inode);
 
-	if (IS_DIRSYNC(inode))
+	if (IS_SYNC(inode))
 		return write_inode_now(inode, 1);
 
-	mark_inode_dirty(inode);
-
 	return 0;
 
 free_clu:
-- 
2.34.1

Re: [PATCH v1] exfat: fix timing of synchronizing bitmap and inode

[Namjae Jeon]

2024년 3월 27일 (수) 오후 6:04, Yuezhang.Mo@sony.com <Yuezhang.Mo@sony.com>님이 작성:
>
> Commit(f55c096f62f1 exfat: do not zero the extended part) changed
> the timing of synchronizing bitmap and inode in exfat_cont_expand().
> The change caused xfstests generic/013 to fail if 'dirsync' or 'sync'
> is enabled. So this commit restores the timing.
>
> Fixes: f55c096f62f1 ("exfat: do not zero the extended part")
> Signed-off-by: Yuezhang Mo <Yuezhang.Mo@sony.com>
Applied it to #dev. Thanks for your patch!